Skip to content

Parse arbitrary precision integers ..#90

Closed
hhugo wants to merge 5 commits intocamlp4:trunkfrom
hhugo:lex1
Closed

Parse arbitrary precision integers ..#90
hhugo wants to merge 5 commits intocamlp4:trunkfrom
hhugo:lex1

Conversation

@hhugo
Copy link
Copy Markdown
Contributor

@hhugo hhugo commented May 11, 2015

ocaml/ocaml#170
ocaml/ocaml#155

Not ready to merge as it fails to parse non-standard modifier ([^nlL]) and does not give good error msg.

$cat test.ml
let x = 12222i

$ camlp4o test.ml
File "test.ml", line 2, characters 6-7:
Parse error: [expr] expected after "=" (in [cvalue_binding])

@hhugo hhugo mentioned this pull request May 11, 2015
Closed
@gasche
Copy link
Copy Markdown
Collaborator

gasche commented Jul 26, 2015

What is the status of this PR? The OCaml-side one seems ready to merge, should merge it without waiting for the Camlp4 side? My natural inclination would rather be to wait for a @diml - approved patch to be merged here, and merge the ocaml-side branch right after that (without the travis-ci blurb).

@ghost
Copy link
Copy Markdown

ghost commented Jul 27, 2015

The changes to Camlp4Ast2OCamlAst are ready to be merged once ocaml/ocaml#170 is merged. This will ensure Camlp4 builds with trunk.

The patch also modifies the token type and the lexer but doesn't change the Camlp4 AST. Unless the Camlp4 AST is updated as well I don't think I'll merge these modifications as it creates incompatibilities for no real benefit.

@hhugo
Copy link
Copy Markdown
Contributor Author

hhugo commented Jul 27, 2015

#91 should replace this PR

@ghost ghost closed this Jul 27, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hhugo @gasche