Admission check endpoint #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameri
reviewed
Sep 9, 2023
| const pubkey = request.params.pubkey | ||
| const user = await this.userRepository.findByPubkey(pubkey) | ||
|
|
||
| console.log('user', user) |
cameri
reviewed
Sep 9, 2023
| } | ||
|
|
||
| public async isRateLimited(request: Request, settings: Settings) { | ||
| const rateLimits = path(['limits', 'invoice', 'rateLimits'], settings) |
Owner
There was a problem hiding this comment.
We should have a different rate limit for this endpoint
cameri
approved these changes
Sep 9, 2023
auto-merge was automatically disabled
September 12, 2023 08:23
Head branch was pushed to by a user without write access
Contributor
Author
|
I'm sorry, I missed a crucial commit... I think this structure makes more sense. Another commit is coming with an addressed rate limits comment. |
Owner
|
@medjedovicm ive fixed the integration tests, do you mind rebasing off the main branch to incorporate the fix into yours? |
Contributor
Author
|
@cameri Yes sure, done. |
Collaborator
Pull Request Test Coverage Report for Build 7506254600
💛 - Coveralls |
cameri
approved these changes
Jan 12, 2024
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created
admission routerandadmission check controllerwhich runs a check against the providedpubkeyin the URL parameter and returns JSON with information if the user (pubkey) is admitted or not.GET/admissions/check/:pubkeyResponse:
Related Issue
Closes #336
Motivation and Context
In our use case, we need to check if a user is admitted on our own relay before we let them log in.
The user is redirected to the relay page (in the new tab) while we send a check request every 10 seconds or so, so we can automatically figure out when payment is done.
How Has This Been Tested?
Visited a new endpoint in the browser, looking for the response.
As far as I am aware my changes do not affect any other parts of the code.
Screenshots (if appropriate):
Types of changes
Checklist: