feat: Implement breakpoint resume functionality for failed tasks#3756
feat: Implement breakpoint resume functionality for failed tasks#3756Zephyroam wants to merge 15 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
You designed an entire serialize → store → deserialize pipeline to maintain the agent’s context, but I think this workflow is overly complex and introduces a number of issues, for example, _save_breakpoint_history is invoked repeatedly, and exceptions can cause agent leakage.
Why don’t we simply avoid releasing the agent when a task fails and reuse the existing instance directly instead?
Done. Thanks @nitpicker55555 |
8f6afdf to
76828b9
Compare
|
@nitpicker55555 Done. Also fixed other possible memory leaks. |
nitpicker55555
left a comment
There was a problem hiding this comment.
Thanks @Zephyroam for this contribution, LGTM! @Wendong-Fan can you take time to check?
waleedalzarooni
left a comment
There was a problem hiding this comment.
Great job @Zephyroam, A quick comment on my side, would be great to see some unit tests.
|
Done, thanks @waleedalzarooni |
|
Please review this @Wendong-Fan Thanks. |
Description
Fixes #3739
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!