This repository was archived by the owner on Sep 2, 2024. It is now read-only.
Merged
Conversation
bigludo7
reviewed
Mar 23, 2023
Contributor
bigludo7
left a comment
There was a problem hiding this comment.
Hi Ruben
Line 9 describe timePeriod and not moneyAmount
start_date & end_date should be camelCase.
Thanks.
Fix some name convention
Contributor
Author
|
Fixed, thanks @bigludo7 |
Fixed line 9: should be TimePeriod and not MoneyAmount.
bigludo7
reviewed
Mar 28, 2023
Contributor
bigludo7
left a comment
There was a problem hiding this comment.
Fixed line 9: should be TimePeriod and not MoneyAmount.
else this fine for me.
Thanks
This was referenced Mar 29, 2023
RubenBG7
commented
Mar 30, 2023
Contributor
Author
RubenBG7
left a comment
There was a problem hiding this comment.
Agree from my side
jordonezlucena
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted structures not used in current CAMARA Subprojects and added new structures of errors prediscussed in last commonalities calls.
Fixes #172