Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

Change status to integer from string#145

Merged
eric-murray merged 1 commit intomainfrom
RubenBG7-patch-3
Feb 2, 2023
Merged

Change status to integer from string#145
eric-murray merged 1 commit intomainfrom
RubenBG7-patch-3

Conversation

@RubenBG7
Copy link
Contributor

@RubenBG7 RubenBG7 commented Feb 2, 2023

Fixes #143

@eric-murray eric-murray merged commit 4bcc5bf into main Feb 2, 2023
@shilpa-padgaonkar
Copy link
Contributor

Would have preferred
"code": 400,
"status": "INVALID_ARGUMENT",

as (personal preference ) code seems more close to http status code. But fine with this option as well if rest are fine with it :)

@eric-murray
Copy link
Contributor

status is the name used in RFC 7807. I think developers will generally be expecting status to be the HTTP status code. The RFC 7807 name for what CAMARA call code is actually title.

@shilpa-padgaonkar
Copy link
Contributor

then all good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design Guidelines: HTTP Status Code type should be Integer, not String

3 participants