fix: include data as mandatory on callback events#94
Merged
stroncoso-quobis merged 2 commits intocamaraproject:mainfrom Jul 28, 2025
Merged
Conversation
deepakjaiswal1
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Current webrt-events API version defined, as mandatory, fields inside the data object, not the data object itself, so this lead to an incorrect API representation.
Moreover, callback events must include data relevant to their use cases, so it is required to dive into the required data notified. In consequence, this PR tries to cover the data required on each specific event.
Which issue(s) this PR fixes:
Fixes #84
Special notes for reviewers:
Based on the solution purposed by @teikuran , with some addons:
EventRegistrationEndsalso requires now a data fieldMediaSessionInfonrationwas renamed to prototypeMediaSession, that requiresmediaSessionIdMediaSessionStatusUpdate, used byEventSessionStatusrequiresstatusfieldMediaSessionInvite, used byEventSessionInvitationrequiresoriginatorAddressandreceiverAddressfieldsChangelog input
Additional documentation
n/a