88 commonalities 060#90
Merged
stroncoso-quobis merged 10 commits intocamaraproject:mainfrom Jul 16, 2025
Merged
Conversation
pradeepachar-mavenir
previously approved these changes
Jul 3, 2025
- Allow multiple event suscription types per susbcription
- replaced subscription-ends with subscription-ended (doc & yaml) - replaced and reviewed callback example - sink pattern added - INVALIND_SINK error added - INVALID_TOKEN_CONTEXT error removed
18fbc63 to
fd7574b
Compare
Collaborator
Author
|
Hi @pradeepachar-mavenir , @rartych , Commonalities review completed. No main functionality changes, but a lot of small changes. I follow the Analysis of Commonalities 0.6.0-rc.1 changes page to complete the cahnges. To facilitate the changes review, I separate each commit with each PR covered on the 0.6.0 release. Including as commit text the release notes comment of each issue. For instance:
I thought that the best way to review the changes is review the commit story (all for today as I force-pushed the rebase) here: https://github.com/camaraproject/WebRTC/pull/90/commits If any extra review is required, please, let me know. Best regards, |
Closed
26 tasks
pradeepachar-mavenir
approved these changes
Jul 15, 2025
deepakjaiswal1
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
meta release fall25 must comply with commonalities 0.6.0
Which issue(s) this PR fixes:
Fixes #88
Special notes for reviewers:
For future reference:
Changelog input
Additional documentation
n/a