Skip to content

Update BYON-CallHandling-Service.yaml - 201 session created, 200 session updated, 204 session updated & examples #44

Merged
TEF-RicardoSerr merged 3 commits intocamaraproject:mainfrom
deepakjaiswal1:main
Jul 4, 2024
Merged

Update BYON-CallHandling-Service.yaml - 201 session created, 200 session updated, 204 session updated & examples #44
TEF-RicardoSerr merged 3 commits intocamaraproject:mainfrom
deepakjaiswal1:main

Conversation

@deepakjaiswal1
Copy link
Collaborator

What type of PR is this?

This PR updates the Swagger documentation for the BYON-CallHandling-Service:
a) Adds a 201 Created response for the (POST) VoIP session creation.
b) Adds a 204 No Content response for updating (PUT) VoIP session status when no response body is received.
c) Updates the 200 OK response for updating (PUT) VoIP session status when a response body is received.
d) Adds examples.

@deepakjaiswal1
Copy link
Collaborator Author

@pradeepachar-mavenir @TEF-RicardoSerr Please review the changes in this PR.

Copy link
Contributor

@TEF-RicardoSerr TEF-RicardoSerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented in the meeting, looks good overall, it is just needed to adreess the errors raised by megalinter

@deepakjaiswal1
Copy link
Collaborator Author

@TEF-RicardoSerr @pradeepachar-mavenir Removed MegaLinter errors.

Copy link
Contributor

@TEF-RicardoSerr TEF-RicardoSerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants