Skip to content

refactor!: move discovery operation from GET to POST#78

Merged
Kevsy merged 3 commits intomainfrom
Kevsy-patch-11
Feb 27, 2025
Merged

refactor!: move discovery operation from GET to POST#78
Kevsy merged 3 commits intomainfrom
Kevsy-patch-11

Conversation

@Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Feb 26, 2025

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

  1. Changes the API operation method from GET to POST
  2. Removes the request headers
  3. Adds a request body containing an optional Device object

Why we need it: to align with other CAMARA APIs (SED was the only API using GET with request headers for device identifiers)

Which issue(s) this PR fixes:

Fixes #74

Special notes for reviewers:

Note that the developer documentation has not been updated yet to reflect this change. Once the PR is agreed then I can fix #75 which covers that.

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Feb 26, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ OPENAPI spectral 1 0 1.66s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.7s
✅ YAML yamllint 1 0 0.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@JoseMConde
Copy link
Contributor

LGTM

@Kevsy Kevsy merged commit dff7026 into main Feb 27, 2025
2 checks passed
@Kevsy Kevsy mentioned this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update examples and usage description following refactoring to POST refactor!: move discovery operation from GET to POST

2 participants