Skip to content

PR for v0.11.0-rc.2#37

Merged
Kevsy merged 2 commits intomainfrom
Kevsy-patch-3
Aug 22, 2024
Merged

PR for v0.11.0-rc.2#37
Kevsy merged 2 commits intomainfrom
Kevsy-patch-3

Conversation

@Kevsy
Copy link
Contributor

@Kevsy Kevsy commented Aug 20, 2024 •
edited
Loading

What type of PR is this?

Add one of the following kinds:

  • correction
  • documentation

What this PR does / why we need it:

Fixes issues raised following v0.11.0 rc.1 and further changes in Commonalities/ICM

Which issue(s) this PR fixes:

Fixes #33
Fixes #34
Fixes #35
Fixes #36

Changelog input

v0.11.0-rc.2

Fixed:
* camaraproject/SimpleEdgeDiscovery/issues/33
* camaraproject/SimpleEdgeDiscovery/issues/34
* camaraproject/SimpleEdgeDiscovery/issues/35
* camaraproject/SimpleEdgeDiscovery/issues/36

@Kevsy Kevsy self-assigned this Aug 20, 2024
@github-actions
Copy link

github-actions bot commented Aug 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.67s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.66s
✅ YAML yamllint 1 0 0.32s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@Kevsy
Copy link
Contributor Author

Kevsy commented Aug 20, 2024

@hdamker This fixes the issues solved in the recent changes to Commonalities & ICM, and increments the version to v0.11.0-rc.2

@jpengar This latest version updates rc.1 to align with the latest requirements , so it may be better to defer the review at camaraproject/IdentityAndConsentManagement#189 until this PR is approved/merged.

@hdamker
Copy link
Contributor

hdamker commented Aug 20, 2024

@Kevsy The fixes are looking good to me.

As you have here incremented the version and declared it as 0.11.0-rc.2 I assume that you want to create a release r1.2 with this PR. For that please add the necessary changes to this PR:

  • update of CHANGELOG (with just the fixes), now you are aligned with Commonalities 0.4.0-rc.2 and ICM 0.2.0-rc.2 :-)
  • update of readiness checklist (as needed)

If you don't want to create a new pre-release with this PR, set the version to "wip".

@Kevsy Kevsy mentioned this pull request Aug 22, 2024
Closed
@Kevsy Kevsy merged commit 188f7d0 into main Aug 22, 2024
@Kevsy Kevsy deleted the Kevsy-patch-3 branch March 4, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crissancas crissancas Awaiting requested review from crissancas crissancas is a code owner

1 more reviewer

@javierlozallu javierlozallu javierlozallu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Kevsy Kevsy

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@Kevsy @hdamker @javierlozallu