Skip to content

chore/make-response-properties-required#97

Merged
DT-DawidWroblewski merged 1 commit intocamaraproject:mainfrom
fernandopradocabrillo:chore/make-response-properties-required
Mar 21, 2024
Merged

chore/make-response-properties-required#97
DT-DawidWroblewski merged 1 commit intocamaraproject:mainfrom
fernandopradocabrillo:chore/make-response-properties-required

Conversation

@fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

  1. Make proeperties "latestSimChange" and "swapped" required since according to agreement they will always be present in the response.
  2. Update description to "retrieve-date" behaviour to reflect agreement

Which issue(s) this PR fixes:

Fixes #96
Fixes #16

Copy link
Collaborator

@DT-DawidWroblewski DT-DawidWroblewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DT-DawidWroblewski DT-DawidWroblewski merged commit a3be3dc into camaraproject:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make response properties required Return value for swap_date when unavailable or unknown

2 participants