Merged
Conversation
Added API documentation for the 2-endpoints SIM Swap API
jlurien
reviewed
Dec 20, 2022
Collaborator
jlurien
left a comment
There was a problem hiding this comment.
Please review the suggestions and feel free to accept or comment. Thanks for providing this
monamok
reviewed
Dec 21, 2022
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Changes ISV (Independent Software Provider) to SP
bigludo7
commented
Dec 27, 2022
Collaborator
Author
bigludo7
left a comment
There was a problem hiding this comment.
Changed ISV to SP
monamok
previously approved these changes
Dec 28, 2022
Contributor
monamok
left a comment
There was a problem hiding this comment.
Added some small coments but it looks good.
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Co-authored-by: Mona Mokhber <mona.mokhber@telefonica.com>
Fixed ### 4.4 Policies formatting.
bigludo7
commented
Dec 28, 2022
Collaborator
Author
bigludo7
left a comment
There was a problem hiding this comment.
Fixed ### 4.4 Policies formatting.
Collaborator
Author
|
Thanks @monamok for this final review. |
Contributor
@bigludo7 please check ### 4.3 Errors too. |
Fixing formatting
bigludo7
commented
Dec 28, 2022
Collaborator
Author
bigludo7
left a comment
There was a problem hiding this comment.
Fixing formatting.
Collaborator
Author
|
@DT-DawidWroblewski Now that the swagger is merged could you please review and/or approve the PR for the documentation. |
DT-DawidWroblewski
approved these changes
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added API documentation for the 2-endpoints SIM Swap API