More details about SimSwap in the API documentation#82
Merged
fernandopradocabrillo merged 4 commits intocamaraproject:mainfrom Dec 11, 2023
Merged
More details about SimSwap in the API documentation#82fernandopradocabrillo merged 4 commits intocamaraproject:mainfrom
fernandopradocabrillo merged 4 commits intocamaraproject:mainfrom
Conversation
- More explicit definition of SimSwap in the API description - More detailed description of scenarios where SimSwap happens and API can be used.
Collaborator
fernandopradocabrillo
left a comment
There was a problem hiding this comment.
Thanks @gregory1g for the PR.
Just a couple suggestions, the rest is fine for me
ok Co-authored-by: Fernando Prado Cabrillo <pradocabrillo.fernando@gmail.com>
Co-authored-by: Fernando Prado Cabrillo <pradocabrillo.fernando@gmail.com>
Contributor
Author
|
Updated following @fernandopradocabrillo suggestions. |
bigludo7
approved these changes
Dec 1, 2023
Collaborator
|
@gregory1g merged since it has 2 codeowner approvals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More explicit definition of SimSwap in the API description.
More detailed description of scenarios where SimSwap happens and API can be used.
What type of PR is this?
documentation
Which issue(s) this PR fixes: