Skip to content

Include 403 INVALID_TOKEN_CONTEXT and SUBSCRIPTION_DELETED terminationReason#200

Merged
fernandopradocabrillo merged 1 commit intocamaraproject:maintenance-r1from
fernandopradocabrillo:maintenance-r1
Mar 27, 2025
Merged

Include 403 INVALID_TOKEN_CONTEXT and SUBSCRIPTION_DELETED terminationReason#200
fernandopradocabrillo merged 1 commit intocamaraproject:maintenance-r1from
fernandopradocabrillo:maintenance-r1

Conversation

@fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction

What this PR does / why we need it:

This PR includes two fixes into Fall24 sim swap subscriptions API:

  1. HTTP 403 INVALID_TOKEN_CONTEXT error
  2. SUBSCRIPTION_DELETED terminationReason for SUBSCRIPTION_ENDS event
  3. Include subscription for this terminationReason

Which issue(s) this PR fixes:

Fixes #196

Special notes for reviewers:

This changes will be included in v0.1.2 of sim-swap-subscriptions which is the version belonging to the Fall24 meta-release

@fernandopradocabrillo fernandopradocabrillo added the Fall24 Fall 24 release preparation label Mar 26, 2025
bigludo7
bigludo7 previously approved these changes Mar 26, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has the wrong merge target if you want to create a patch of r1.3. It must be camaraproject:maintenance-r1 (to be created as first step before the PR in the camaraproject repository).

See also #196 (comment)

@fernandopradocabrillo fernandopradocabrillo changed the base branch from main to maintenance-r1 March 27, 2025 11:12
@fernandopradocabrillo fernandopradocabrillo dismissed bigludo7’s stale review March 27, 2025 11:12

The base branch was changed.

@hdamker
Copy link
Collaborator

hdamker commented Mar 27, 2025

Now it looks right to me :-)

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo fernandopradocabrillo merged commit 24d46df into camaraproject:maintenance-r1 Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fall24 Fall 24 release preparation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SUBSCRIPTION_DELETED event and INVALID_TOKEN_CONTEXT error missing in Fall24 v0.1.1 sim-swap-subscriptions

3 participants