Guidelines alignment errors and camel case#20
Merged
DT-DawidWroblewski merged 2 commits intocamaraproject:mainfrom Mar 31, 2023
Merged
Conversation
bigludo7
approved these changes
Mar 29, 2023
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Checked and look good for me !
Thanks
Contributor
Author
|
Dear @DT-DawidWroblewski could you please take a look and if it's ok go ahead and merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will handle issue#21
The modified parts are just the errors and parmeters but for some reason I was not able to avoid GIT from showing deleting and readding the same lines. Here you can find the diffrences.
I renamed the file as the version was hard coded in the name and it's not valid anymore.
cc: @jlurien