Skip to content

[Sim-Swap-Subscription]: Add TerminationReason SUBSCRIPTION_DELETED#177

Merged
bigludo7 merged 4 commits intocamaraproject:mainfrom
daniel-dierich:main
Dec 16, 2024
Merged

[Sim-Swap-Subscription]: Add TerminationReason SUBSCRIPTION_DELETED#177
bigludo7 merged 4 commits intocamaraproject:mainfrom
daniel-dierich:main

Conversation

@daniel-dierich
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Adds TerminationReason SUBSCRIPTION_DELETED

Which issue(s) this PR fixes:

Fixes #172

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator

Hi @daniel-dierich
May I ask to change the version in the yam to wip.
Lines 64 & 71.

I will then merge this one. It will be part of next release.
Thanks

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version to wip lines 64 & 71

bigludo7
bigludo7 previously approved these changes Dec 16, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit fff1a27 into camaraproject:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Termination Reason SUBSCRIPTION_DELETED

3 participants