[sim-swap-subscriptions]: remove allof in sinkcredential#175
[sim-swap-subscriptions]: remove allof in sinkcredential#175bigludo7 merged 3 commits intocamaraproject:mainfrom
allof in sinkcredential#175Conversation
allof in sinkcredential
bigludo7
left a comment
There was a problem hiding this comment.
LGTM
Aligned with commonalities event-subscription-template.yaml
|
@fernandopradocabrillo This request is aligned with current commonalities rules (here line 299-300) so I guess we can merge it and have in r1.4. WDYT? |
Fine for me. It doesn't change the API functionality, just the structure of the schema so I don't think we need to update the API version. We can include it, I'll remove the don't merge tag |
|
Hello @dfischer-tech I will then merge this one. It will be part of next release. |
bigludo7
left a comment
There was a problem hiding this comment.
May I ask to change the version in the yam to wip.
Lines 64 & 71.
|
@dfischer-tech @fernandopradocabrillo I've changed the version accordingly. Fernando if ok for you we can merge :) |
e664361
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Removing this
allOf.It was discovered for some code-generator, it will produce unexpected behaviours having the
descriptioninside theallOf.Which issue(s) this PR fixes:
Fixes #174
Changelog input