Skip to content

Add EventSimSwap to Sim Swap Subscriptions#157

Merged
bigludo7 merged 5 commits intocamaraproject:mainfrom
daniel-dierich:main
Oct 17, 2024
Merged

Add EventSimSwap to Sim Swap Subscriptions#157
bigludo7 merged 5 commits intocamaraproject:mainfrom
daniel-dierich:main

Conversation

@daniel-dierich
Copy link
Contributor

@daniel-dierich daniel-dierich commented Oct 16, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Adds the event for a sim swap to the API specification for sim-swap-subscriptions.

Which issue(s) this PR fixes:

Fixes #156

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 16, 2024 •
edited
Loading

@daniel-dierich Thanks - Yes we should fix this !

Are you able to manage EasyCLA with your company to LF?
If not let me know and I can craft the PR to fix this.

Thanks a lot for the contribution.

We have to remove as well

    Event-typeEvent:
      description: event structure for event-type event
      allOf:
        - $ref: "#/components/schemas/CloudEvent"
        - type: object

(lines 681-685)

bigludo7
bigludo7 previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 17, 2024

@daniel-dierich if you have issue/question related to easyCLA --> @wrathwolf can help.

@daniel-dierich
Copy link
Contributor Author

daniel-dierich commented Oct 17, 2024

I have been added to the easyCLA of my company but I seem unable to restart the check.

@bigludo7
Copy link
Collaborator

bigludo7 commented Oct 17, 2024

I have been added to the easyCLA of my company but I seem unable to restart the check.

Perhaps it requires some time?
I'v send a check - only megalinter is checked.
BTW you have a trailing space un line 680 making megalinter unhappy.

bigludo7
bigludo7 previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fernandopradocabrillo
Copy link
Collaborator

fernandopradocabrillo commented Oct 17, 2024

@daniel-dierich Thanks for the PR!

please could you also change the API version to wip and the url server version to vwip?

fernandopradocabrillo
fernandopradocabrillo approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bigludo7 bigludo7 self-requested a review October 17, 2024 12:14
bigludo7
bigludo7 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit 9e05324 into camaraproject:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Sim-Swap-Subscription]: EventSimSwap is missing

3 participants

@daniel-dierich @bigludo7 @fernandopradocabrillo