Skip to content

Release r1.1. with API version v0.1.0-rc.1#28

Merged
eric-murray merged 12 commits intomainfrom
v0.1.0-rc.1
Jul 24, 2025
Merged

Release r1.1. with API version v0.1.0-rc.1#28
eric-murray merged 12 commits intomainfrom
v0.1.0-rc.1

Conversation

@albertoramosmonagas
Copy link
Contributor

@albertoramosmonagas albertoramosmonagas commented Jul 8, 2025

What type of PR is this?

Add one of the following kinds:

  • correction
  • documentation

What this PR does / why we need it:

This PR aligns the predictive connectivity data api with Commonalities and ICM for the CAMARA Meta Release Fall25 and with the closed scope of the group to release the first release candidate.

Which issue(s) this PR fixes:

Fixes #17

Special notes for reviewers:

The scope has been closed in the previous PRs.

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Jul 8, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.02s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.57s
✅ YAML yamllint 1 0 0.35s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@albertoramosmonagas albertoramosmonagas requested a review from a team July 8, 2025 12:43
@hdamker hdamker mentioned this pull request Jul 8, 2025
Closed
26 tasks
bigludo7
bigludo7 reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
I did a first review from Release Management perspective.
Few things to update but we need also the feature file for test definition to move forward.

About my comments in the CHANGELOG.md I tend to think that internal project PR should not be listed and only PR relevant for the developer wanting to use our API.

@albertoramosmonagas
Copy link
Contributor Author

albertoramosmonagas commented Jul 17, 2025

Hello I did a first review from Release Management perspective. Few things to update but we need also the feature file for test definition to move forward.

About my comments in the CHANGELOG.md I tend to think that internal project PR should not be listed and only PR relevant for the developer wanting to use our API.

Hello, I have fixed everything that was mentioned and we are waiting to upload the test file.

@bigludo7
Copy link
Contributor

bigludo7 commented Jul 17, 2025

Hello, I have fixed everything that was mentioned and we are waiting to upload the test file.

Thanks @albertoramosmonagas - just re-request review from me when it available and I will do final review. Thanks!

hdamker
hdamker reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question ... as we should avoid abbreviations wherever possible.

@albertoramosmonagas
fix: error enum and description bugs detected during ATP review
9e05da4 
Corrected inconsistencies in error documentation:
- Some error codes had the correct enum but referenced the wrong API in the description (e.g. 'Population Density Data' prefix instead of the correct one).
- Others had correct descriptions but incorrect enum references.

These bugs were identified during ATP by Alberto Ramos Monagas and are required fixes for RC compliance.
@albertoramosmonagas
add change to the checklist for test
267b38c
@albertoramosmonagas
add a new line at the end of the file for linting rules
a794036
@albertoramosmonagas
add a new line at the end of the file for linting rules
a82370f
@albertoramosmonagas
Copy link
Contributor Author

albertoramosmonagas commented Jul 23, 2025

@eric-murray Tests uploaded, there's nothing else left for us to do. Please take a look if you can! Thank you very much.

hdamker
hdamker reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two points on the test files which I have spotted. RM review is still with @bigludo7

albertoramosmonagas and others added 2 commits July 23, 2025 15:32
@albertoramosmonagas @hdamker
Update code/Test_definitions/predictive-connectivity-data.feature.md
d70eb50 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@albertoramosmonagas @hdamker
Update code/Test_definitions/predictive-connectivity-data.feature.md
4629da9 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
hdamker
hdamker reviewed Jul 23, 2025
View reviewed changes
bigludo7
bigludo7 reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look very good for me - a small mistype on line 9 of the feature file and we're good.

albertoramosmonagas and others added 2 commits July 23, 2025 16:04
@albertoramosmonagas @hdamker
Update code/API_definitions/predictive-connectivity-data.yaml
4cae202 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@albertoramosmonagas
solve small mistype
30f6817
bigludo7
bigludo7 previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@bigludo7 bigludo7 left a comment •
edited by albertoramosmonagas
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good on behalf of the Release Management team.

Next actions to fulfill M3:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

eric-murray
eric-murray reviewed Jul 23, 2025
View reviewed changes
@albertoramosmonagas @eric-murray
Apply suggestions from code review
fce8e70 
Change "N" to "Y" on checklist and some minor changes

Co-authored-by: Eric Murray <eric.murray@vodafone.com>
@albertoramosmonagas
Copy link
Contributor Author

albertoramosmonagas commented Jul 23, 2025

Thanks for all your comments @eric-murray! I had overlooked the checklist column! If there is nothing else relevant, I think we can merge the PR.

bigludo7
bigludo7 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch from Eric !
I approve again on behalf of the RM team

@eric-murray eric-murray merged commit 3dd308c into main Jul 24, 2025
2 checks passed
@eric-murray eric-murray deleted the v0.1.0-rc.1 branch July 24, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hdamker hdamker hdamker left review comments

@bigludo7 bigludo7 bigludo7 approved these changes

@eric-murray eric-murray eric-murray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API predictive-connectivity-data version 0.1.0 functional enhancements

4 participants

@albertoramosmonagas @bigludo7 @hdamker @eric-murray