Skip to content

Align commonalities with v0.6-rc1#21

Merged
eric-murray merged 4 commits intomainfrom
commonalities-v0.6-rc1
Jun 30, 2025
Merged

Align commonalities with v0.6-rc1#21
eric-murray merged 4 commits intomainfrom
commonalities-v0.6-rc1

Conversation

@albertoramosmonagas
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature
  • documentation

What this PR does / why we need it:

Following the pre-release of commonalities v0.6-rc1 and the fall25 M3 deadline, commonalities v0.6-rc1 has been adapted to commonalities v0.6-rc1.

Which issue(s) this PR fixes:

Fixes #15

Special notes for reviewers:

N/A

Changelog input

Align commonalities with v0.6-rc1
 release-note

Additional documentation

This section can be blank.

docs

@albertoramosmonagas
Copy link
Contributor Author

@eric-murray the PR has been adapted to commonalities v0.6-rc1

@eric-murray
Copy link
Contributor

@albertoramosmonagas
If you want to comply with the Commonalities Design Guide, you will need to rename the file to predictive-connectivity-data.yaml. As file renaming means github will no longer show individual changes within the file, I'd suggest to do this once the other changes are finalised.

@albertoramosmonagas
Copy link
Contributor Author

albertoramosmonagas commented Jun 27, 2025

If you want to comply with the Commonalities Design Guide, you will need to rename the file to predictive-connectivity-data.yaml. As file renaming means github will no longer show individual changes within the file, I'd suggest to do this once the other changes are finalised.

I modify it! thank you @eric-murray, can you approve and merge the PR?

@hdamker
Copy link
Contributor

hdamker commented Jun 29, 2025

As file renaming means github will no longer show individual changes within the file, I'd suggest to do this once the other changes are finalised.

@eric-murray interesting: even after @albertoramosmonagas renamed the file, GitHub is still showing the individual changes. Might be because: the branch is within the upstream repository and the name change was done within GitHub.

@albertoramosmonagas
Copy link
Contributor Author

@eric-murray can you merge the current PR to create the rc?

@eric-murray
Copy link
Contributor

@eric-murray interesting: even after @albertoramosmonagas renamed the file, GitHub is still showing the individual changes. Might be because: the branch is within the upstream repository and the name change was done within GitHub.

Yes, I've not seen that before. Might be a new feature! More likely, there is a "right" way to rename a file (i.e. just rename it) and a "wrong" way (delete the old file and upload a "new" file with the new name), and github can only show changes when it is done in the right way.

@eric-murray eric-murray merged commit 1d95afe into main Jun 30, 2025
1 check passed
@hdamker
Copy link
Contributor

hdamker commented Jun 30, 2025

@eric-murray interesting: even after @albertoramosmonagas renamed the file, GitHub is still showing the individual changes. Might be because: the branch is within the upstream repository and the name change was done within GitHub.

Yes, I've not seen that before. Might be a new feature! More likely, there is a "right" way to rename a file (i.e. just rename it) and a "wrong" way (delete the old file and upload a "new" file with the new name), and github can only show changes when it is done in the right way.

https://docs.github.com/en/repositories/working-with-files/managing-files/renaming-a-file ... outside of GitHub it is important to be certain that the result is a "git mv ...", not a delete and new file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API predictive-connectivity-data version 0.1.0 alignment with transversal

3 participants