Skip to content

Alignment with Commonalities r3.3#94

Merged
jgarciahospital merged 6 commits intocamaraproject:mainfrom
albertoramosmonagas:align/commonalities-r3.3
Aug 29, 2025
Merged

Alignment with Commonalities r3.3#94
jgarciahospital merged 6 commits intocamaraproject:mainfrom
albertoramosmonagas:align/commonalities-r3.3

Conversation

@albertoramosmonagas
Copy link
Contributor

@albertoramosmonagas albertoramosmonagas commented Aug 19, 2025 •
edited
Loading

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

  • ErrorInfo schema unified with CAMARA_common.yaml and event-subscription-template.yaml → reordered required fields, clarified message, status, and code descriptions.
  • Updated mandatory description for date-time string format in template files.
  • Updates to ATP: added geohash checks (scenarios 01 & 07), included missing async operation scenario, reorganized by HTTP codes, fixed sinkCredential typo, and minor corrections.

Which issue(s) this PR fixes:

Fixes #93

Special notes for reviewers:

Nothing relevant, everything comes from the latest changes in commonalities.

Changelog input

 release-note
Alignment with Commonalities r3.3 – unified ErrorInfo schema (fields reordered, clarified descriptions for message, status, and code) and updated mandatory description for date-time format and solve fixes on ATP

Additional documentation

N/A

docs

sachinvodafone
sachinvodafone previously approved these changes Aug 19, 2025
View reviewed changes
jgarciahospital
jgarciahospital previously approved these changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@jgarciahospital jgarciahospital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertoramosmonagas
Copy link
Contributor Author

albertoramosmonagas commented Aug 21, 2025

@sachinvodafone @maheshc01

I made one last change to the test file with some typos. Can you check it? With the last commit, I lost the approvals.

Thank you very much in advance

Alberto

sachinvodafone
sachinvodafone previously approved these changes Aug 21, 2025
View reviewed changes
maheshc01
maheshc01 previously approved these changes Aug 21, 2025
View reviewed changes
@hdamker hdamker mentioned this pull request Aug 23, 2025
Merged
jgarciahospital
jgarciahospital approved these changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@jgarciahospital jgarciahospital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital jgarciahospital merged commit e2a8172 into camaraproject:main Aug 29, 2025
2 checks passed
@hdamker hdamker mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinvodafone sachinvodafone sachinvodafone approved these changes

@jgarciahospital jgarciahospital jgarciahospital approved these changes

@maheshc01 maheshc01 Awaiting requested review from maheshc01 maheshc01 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alignment with Commonalities r3.3 & ATP

4 participants

@albertoramosmonagas @sachinvodafone @maheshc01 @jgarciahospital