Fall25 - M3 milestone - Prepare r3.1 by jgarciahospital · Pull Request #91 · camaraproject/PopulationDensityData

jgarciahospital · 2025-06-24T14:47:46Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

Implements API alignement with fall25
Version update to 0.3.0-rc.1
CHANGELOG.MD, READ.ME & Readiness check list updated version are provided for r3.1

Which issue(s) this PR fixes:

Fixes #79

Special notes for reviewers:

Changelog input

 release-note

typo in rc version

typo on rc version

github-actions · 2025-06-24T14:49:33Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Errors	Elapsed time
✅ ACTION	actionlint	2	0	0.02s
✅ OPENAPI	spectral	1	0	1.71s
✅ REPOSITORY	git_diff	yes	no	0.03s
✅ REPOSITORY	secretlint	yes	no	0.81s
✅ YAML	yamllint	1	0	0.48s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

Typo in error message for 422

hdamker

Looks already very good ... a few small changes and you are done!

code/Test_definitions/population-density-data.feature

code/API_definitions/population-density-data.yaml

CHANGELOG.md

hdamker · 2025-06-29T11:36:36Z

README.md

+* `NEW`: Pre-release r3.1 with version 0.3.0-rc.1 of the Population Density Data API is available in [r3.1](https://github.com/camaraproject/PopulationDensityData/tree/r3.1).
+* 0.3.0-rc.1 Population Density Data API definition **with inline documentation**:
+  - OpenAPI [YAML spec file](https://github.com/camaraproject/PopulationDensityData/blob/r3.1/code/API_definitions/population-density-data.yaml)
+  - [View it on ReDoc](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/PopulationDensityData/r3.1/code/API_definitions/population-density-data.yaml&nocors)
+  - [View it on Swagger Editor](https://camaraproject.github.io/swagger-ui/?url=https://raw.githubusercontent.com/camaraproject/PopulationDensityData/r3.1/code/API_definitions/population-density-data.yaml)


Personally I'm more in favor to keep the prominent links to the public version (relevant for API Consumers), and only add a line for the pre-release of the next version. But we don't have guidelines yet for this README section, so the content is fine for me.

documentation/API_documentation/population-density-data-API-Readiness-Checklist.md

hdamker · 2025-06-29T11:40:07Z

@camaraproject/population-density-data_codeowners please review as well

code/Test_definitions/population-density-data.feature

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

…adiness-Checklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Include detailed commonalities update

code/API_definitions/population-density-data.yaml

hdamker

@jgarciahospital thanks for the update. I can already confirm that all change requests are addressed.

In the final review I have just spotted one bug which you might want to fix before the release:

PopulationDensityData/code/Test_definitions/population-density-data.feature

Line 59 in e078615

    
           And the response property "$.timedPopulationDensityData[*].endTime" is equal to or earlier than request body property "$.startTime"

I suppose the line should be:

And the response property "$.timedPopulationDensityData[*].endTime" is equal to or earlier than request body property "$.endTime"

jgarciahospital · 2025-07-21T08:27:41Z

@jgarciahospital thanks for the update. I can already confirm that all change requests are addressed.

In the final review I have just spotted one bug which you might want to fix before the release:

PopulationDensityData/code/Test_definitions/population-density-data.feature

Line 59 in e078615

And the response property "$.timedPopulationDensityData[*].endTime" is equal to or earlier than request body property "$.startTime"

I suppose the line should be:

And the response property "$.timedPopulationDensityData[*].endTime" is equal to or earlier than request body property "$.endTime"

Thanks Herbert for the review.

Regarding the identified typo, it's solved now.

hdamker

LGTM on behalf of ReleaseManagement

hdamker · 2025-07-24T07:18:53Z

@camaraproject/population-density-data_codeowners

Next actions to be completed for M3:

PR merged (by API repository codeowner)
Release created within GitHub (by API repository codeowner)
Release Tracker updated (with API version, creation date of the release and the release tag link)

hdamker · 2025-07-28T18:41:25Z

@jgarciahospital @sachinvodafone @maheshc01 would be great if you can approve, merge and create the release until tomorrow (July 29th) before the Release Management call (at 15:00 UTC). From my perspective you should be ready to go.

jgarciahospital added 7 commits June 24, 2025 12:58

Update population-density-data.yaml

01f66a7

Update population-density-data.feature

9bc5fe5

Update CHANGELOG.md

7d41290

Update population-density-data-API-Readiness-Checklist.md

8b21feb

Update README.md

c109833

Update population-density-data.yaml

010a2e2

typo in rc version

Update population-density-data.feature

cae0743

typo on rc version

jgarciahospital requested review from a team, maheshc01 and sachinvodafone as code owners June 24, 2025 14:47

Update CHANGELOG.md

e7470e6

hdamker mentioned this pull request Jun 24, 2025

PopulationDensityData r3.1 (Fall25 M3, update initial API, maybe new stable) release review camaraproject/ReleaseManagement#237

Closed

20 tasks

rartych mentioned this pull request Jun 25, 2025

Pop density -test rartych/tooling#1

Open

26 tasks

Update population-density-data.yaml

41c45ec

Typo in error message for 422

hdamker requested changes Jun 29, 2025

View reviewed changes

hdamker reviewed Jun 29, 2025

View reviewed changes

code/Test_definitions/population-density-data.feature Outdated Show resolved Hide resolved

jgarciahospital and others added 5 commits July 1, 2025 16:55

Update code/Test_definitions/population-density-data.feature

32e5c5a

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update code/API_definitions/population-density-data.yaml

c39b619

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update documentation/API_documentation/population-density-data-API-Re…

0d92a67

…adiness-Checklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update code/Test_definitions/population-density-data.feature

67c1786

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update CHANGELOG.md

da96a2f

Include detailed commonalities update

hdamker mentioned this pull request Jul 1, 2025

Test issue for API Review Workflow hdamker/ReleaseManagement#2

Closed

hdamker reviewed Jul 2, 2025

View reviewed changes

code/API_definitions/population-density-data.yaml Show resolved Hide resolved

Update population-density-data.yaml

e078615

jgarciahospital requested a review from hdamker July 2, 2025 07:51

hdamker previously approved these changes Jul 18, 2025

View reviewed changes

Fix typo in test case

9e9a298

jgarciahospital dismissed hdamker’s stale review via 9e9a298 July 21, 2025 08:27

hdamker approved these changes Jul 23, 2025

View reviewed changes

sachinvodafone approved these changes Jul 29, 2025

View reviewed changes

sachinvodafone merged commit b59f277 into main Jul 29, 2025
2 checks passed

jgarciahospital deleted the jgarciahospital-patch-5 branch July 29, 2025 08:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fall25 - M3 milestone - Prepare r3.1#91

Fall25 - M3 milestone - Prepare r3.1#91
sachinvodafone merged 16 commits intomainfrom
jgarciahospital-patch-5

jgarciahospital commented Jun 24, 2025

Uh oh!

github-actions bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

hdamker left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hdamker Jun 29, 2025

Uh oh!

Uh oh!

hdamker commented Jun 29, 2025

Uh oh!

Uh oh!

Uh oh!

hdamker left a comment •

edited

Loading

Uh oh!

jgarciahospital commented Jul 21, 2025

Uh oh!

hdamker left a comment

Uh oh!

hdamker commented Jul 24, 2025

Uh oh!

hdamker commented Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jgarciahospital commented Jun 24, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Uh oh!

github-actions bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hdamker Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hdamker commented Jun 29, 2025

Uh oh!

Uh oh!

Uh oh!

hdamker left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgarciahospital commented Jul 21, 2025

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

hdamker commented Jul 24, 2025

Uh oh!

hdamker commented Jul 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jun 24, 2025 •

edited

Loading

hdamker left a comment •

edited

Loading