Support time window in the past in the APIexposure of data in the past is added#60
Merged
jgarciahospital merged 8 commits intocamaraproject:mainfrom Jan 28, 2025
Merged
Conversation
sachinvodafone
previously approved these changes
Dec 18, 2024
bigludo7
reviewed
Dec 18, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
One very small fix and one request for clarification please :)
Except that look good for me.
| @population_density_data_retrievePopulationDensity_24_timeframe_crosses_request_time | ||
| Scenario: Error 400 when startDate is set to a date in the past and the endDate is set to a date in the future | ||
| Given the request body property "$.startDate" is set to a date in the past | ||
| And the request body property "$.endDate" is set to a date in teh future |
Collaborator
There was a problem hiding this comment.
date in teh --> date in the
| and must have time zone. Recommended format is yyyy-MM-dd'T'HH:mm:ss.SSSZ | ||
| (i.e. which allows 2023-07-03T14:27:08.312+02:00 or 2023-07-03T12:27:08.312Z) | ||
| The minimum startTime is the time of the request. | ||
| The minimum startTime must cover at least 3 months before the request time. |
Collaborator
There was a problem hiding this comment.
This is not clear for me (but perhaps this is my English).
Do we mean that request in the past must query information older than 3 months or the contrary?
Contributor
Author
There was a problem hiding this comment.
My idea was to declare a minimal time frame everyone must support. I.e. everyone who implements API must support 3 months, if someone exposes 1 year - its a bonus.
sachinvodafone
previously approved these changes
Jan 15, 2025
jgarciahospital
requested changes
Jan 15, 2025
Collaborator
|
@gregory1g please check comments to move forward and close this PR |
Collaborator
|
@gregory1g can you please confirm to move on with the RC creation? |
Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
API definition is enhanced to support dates in the past as well as suggested in issue #51