Skip to content

Simplify class management and change of density value formats#59

Merged
jgarciahospital merged 1 commit intomainfrom
jgarciahospital-patch-4
Dec 19, 2024
Merged

Simplify class management and change of density value formats#59
jgarciahospital merged 1 commit intomainfrom
jgarciahospital-patch-4

Conversation

@jgarciahospital
Copy link
Collaborator

@jgarciahospital jgarciahospital commented Nov 25, 2024

What type of PR is this?

Add one of the following kinds:

  • correction
  • enhancement/feature

What this PR does / why we need it:

Including proposal of solution for:
#56 Mapping of enum and classes in densitydata & simplify class CellPopulationDensityData
#58 Integer value format for population density values

Which issue(s) this PR fixes:

Fixes #56 #58

@jgarciahospital
Copy link
Collaborator Author

jgarciahospital commented Nov 25, 2024 •
edited
Loading

@bigludo7 please for your review

Consider the change in the schemas to validate if this proposal is ok for you, compared with a alternative:

 propertyName: dataType
        mapping:
          NO_DATA: '#/components/schemas/NoDataPopulationDensityData'
          LOW_DENSITY: '#/components/schemas/LowDensityPopulationDensityData'
          DENSITY_ESTIMATION: '#/components/schemas/DensityEstimationPopulationDensityData'

Conscious that in other APIs the mapping is no so strict, e.g. https://github.com/camaraproject/DeviceLocation/blob/main/code/API_definitions/location-retrieval.yaml#L310
https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml

@bigludo7
Copy link
Collaborator

bigludo7 commented Nov 25, 2024

Hello @jgarciahospital
Work for me !
Thanks

@jgarciahospital jgarciahospital merged commit 990d756 into main Dec 19, 2024
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-4 branch December 19, 2024 07:44
@jgarciahospital jgarciahospital mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sachinvodafone sachinvodafone sachinvodafone approved these changes

@bigludo7 bigludo7 Awaiting requested review from bigludo7

@maheshc01 maheshc01 Awaiting requested review from maheshc01 maheshc01 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make the API more developer friendly

3 participants

@jgarciahospital @bigludo7 @sachinvodafone