Skip to content

Prepare release r1.1#41

Merged
hdamker merged 20 commits intomainfrom
jgarciahospital-patch-3
Aug 2, 2024
Merged

Prepare release r1.1#41
hdamker merged 20 commits intomainfrom
jgarciahospital-patch-3

Conversation

@jgarciahospital
Copy link
Collaborator

@jgarciahospital jgarciahospital commented Jul 25, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Prepare the release 1.1 with the required changes to support meta guidelines

@hdamker hdamker mentioned this pull request Jul 25, 2024
Closed
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
hdamker
hdamker reviewed Jul 25, 2024
View reviewed changes
@hdamker
Copy link
Contributor

hdamker commented Jul 25, 2024 •
edited
Loading

@jgarciahospital See my comments above. I assumed in my comments that this will be indeed a release candidate of v0.1.1. Being directly the patch release of v0.1.0 could be another option.

If the changes are done, please add @camaraproject/release-management_maintainers as reviewer.

jgarciahospital and others added 7 commits July 25, 2024 19:10
@jgarciahospital @hdamker
Update CHANGELOG.md
ad1a9aa 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update CHANGELOG.md
d1ec104 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update CHANGELOG.md
14fc3e7 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update README.md
9a39f04 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update README.md
3e43488 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update README.md
3483301 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update code/API_definitions/population-density-data.yaml
da0f270 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update code/Population-Density-Data-API-Readiness-Checklist.md
ae55385 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital jgarciahospital requested a review from a team July 25, 2024 17:12
jgarciahospital and others added 3 commits July 25, 2024 19:12
@jgarciahospital @hdamker
Update README.md
60c1382 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital @hdamker
Update README.md
049c409 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@jgarciahospital
Updating path and links in readiness
fca6856
@jgarciahospital jgarciahospital changed the base branch from release-0.1.1-rc1.1 to main July 26, 2024 16:18
@hdamker hdamker mentioned this pull request Jul 31, 2024
Closed
11 tasks
@hdamker
Copy link
Contributor

hdamker commented Aug 1, 2024

API definition:

@jgarciahospital
Merge branch 'main' into jgarciahospital-patch-3
4ff9741
@jgarciahospital
Update population-density-data.yaml
54d2a29 
Updating Authorization and authentication info section according to las I&CM version
@jgarciahospital
Update CHANGELOG.md
70ed8ea
@jgarciahospital jgarciahospital requested a review from hdamker August 1, 2024 14:56
@jgarciahospital
Copy link
Collaborator Author

jgarciahospital commented Aug 1, 2024

@hdamker ready for new revision of this fields

API definition:

update the Authorization and Authentication text with the latest updates from ICM:
it was in general changed in 0.2.0
there was a last minute update to avoid the link into ICM main branch, see camaraproject/IdentityAndConsentManagement#186, which will be part of the second release candidate of ICM
change the link within line 108 accordingly, as links into 'main' branch will break at some point of time.

Also added #42 for documentation and included in changelog, as agreed in followup meeting#12

hdamker
hdamker reviewed Aug 1, 2024
View reviewed changes
@jgarciahospital @hdamker
Update code/API_definitions/population-density-data.yaml
75795bb 
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
hdamker
hdamker approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Release Management. Please proceed with the release.

@jgarciahospital
Copy link
Collaborator Author

jgarciahospital commented Aug 1, 2024

Looks good from Release Management. Please proceed with the release.

Thanks @hdamker. As no other codeOwner active (holidays), may you validate the PR?

@hdamker
Copy link
Contributor

hdamker commented Aug 1, 2024 •
edited
Loading

Thanks @hdamker. As no other codeOwner active (holidays), may you validate the PR?

I can bypass the rule protection and merge, but would be good if at least one further Sub Project participant would approve the PR before, @gregory1g maybe?

gregory1g
gregory1g approved these changes Aug 2, 2024
View reviewed changes
code/API_definitions/population-density-data.yaml
termsOfService: http://swagger.io/terms/
contact:
email: project-email@sample.com
(FAQs will be added in a later version of the documentation)
Copy link
Contributor

@gregory1g gregory1g Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add "TBD" entry to the released version of the spec?

Copy link
Contributor

@hdamker hdamker Aug 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was copied over from the very first API documentations. A FAQ was never mandatory, even not in the outdated documentation template (which will now get deprecated). So you can delete this line.

Copy link
Contributor

@gregory1g gregory1g Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed it PR #42 . And now it is added back.

@jgarciahospital
Copy link
Collaborator Author

jgarciahospital commented Aug 2, 2024

@hdamker ready now?

@hdamker hdamker merged commit 7232a52 into main Aug 2, 2024
@hdamker hdamker mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hdamker hdamker hdamker approved these changes

@sachinvodafone sachinvodafone Awaiting requested review from sachinvodafone sachinvodafone is a code owner

@maheshc01 maheshc01 Awaiting requested review from maheshc01 maheshc01 is a code owner

+1 more reviewer

@gregory1g gregory1g gregory1g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Fall24 RC1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgarciahospital @hdamker @gregory1g