Skip to content

Creation of v0.1.0-rc version#27

Merged
jgarciahospital merged 3 commits intomainfrom
jgarciahospital-patch-1
Jun 5, 2024
Merged

Creation of v0.1.0-rc version#27
jgarciahospital merged 3 commits intomainfrom
jgarciahospital-patch-1

Conversation

@jgarciahospital
Copy link
Collaborator

What type of PR is this?

  • correction
  • enhancement/feature

What this PR does / why we need it:

Creates the release candidate for version 0.1.0.
Includes modifications of output parameters, as agreed in #23

Which issue(s) this PR fixes:

Fixes #23

Include agreed parameters and definitions for reponse values.
@gregory1g
Copy link
Contributor

The spec still uses "average" in the text. I would suggest to add changes like you can find here: https://github.com/gregory1g/PopulationDensityData/blob/pim_max_avrg_naming/code/API_definitions/population-density-data.yaml

Or I can cerate a alternative pull request from that branch.

@jgarciahospital
Copy link
Collaborator Author

The spec still uses "average" in the text. I would suggest to add changes like you can find here: https://github.com/gregory1g/PopulationDensityData/blob/pim_max_avrg_naming/code/API_definitions/population-density-data.yaml

Or I can cerate a alternative pull request from that branch.

Updated as a new commit, thanks Gregory

@gregory1g
Copy link
Contributor

LGFM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@jgarciahospital jgarciahospital merged commit 07a315d into main Jun 5, 2024
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-1 branch June 5, 2024 12:27
@jgarciahospital jgarciahospital restored the jgarciahospital-patch-1 branch June 10, 2024 18:51
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-1 branch June 10, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion of Response parameter definition

4 participants