Including Population density format in responses#26
Merged
jgarciahospital merged 2 commits intomainfrom May 29, 2024
Merged
Conversation
Contributor
|
Since naming of the attributes is discussed separately, LGTM. I would also consider reanaming of "PopulationData" to "PopulationDensityData". I do not have a strong opinion here - ppl density is still a population data. |
Collaborator
Author
Agreed, we have added that in this PR directly. @gregory1g please validate |
sachinvodafone
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As defined in #14 , response format is now based on population/km2.
Which issue(s) this PR fixes:
Fixes #14