Skip to content

Update population-density-data.yaml#21

Merged
jgarciahospital merged 2 commits intomainfrom
jgarciahospital-patch-1
May 20, 2024
Merged

Update population-density-data.yaml#21
jgarciahospital merged 2 commits intomainfrom
jgarciahospital-patch-1

Conversation

@jgarciahospital
Copy link
Collaborator

@jgarciahospital jgarciahospital commented Apr 24, 2024

PR tracking following issues:

What type of PR is this?

  • correction
  • enhancement/feature

What this PR does / why we need it:

Fixes #6
Fixes #7
Fixes #10
Fixes #13
Fixes #15
Fixes #20

PR fixing following issues:

 - Issue#6 (solved) on water zones treatment: partial supported areas will include all the cells in the response with the value "NO_DATA", and response status "PART_OF_AREA_NOT_SUPPORTED". Completely nos supported areas will include a empty list of cells, and status "AREA_NOT_SUPPORTED"
 - Issue#7 on max/min values: Precision parameter is allowed as input in the request, with a default value of level7. Error "PRECISION_NOT_SUPPORTED" in included. Limit values still to be defined.
 - Issue#10: Async response option added following proposal on Issue#20
 - Issue#13 (solved): Time format now following RFC3339
 - Issue#15 (solved): Aligned area schema following "location API" format
@gregory1g
Copy link
Contributor

looks good for me

Including new error codes to manage unsupported requests
@jgarciahospital
Copy link
Collaborator Author

Solving #7 #10 and minor bugs

@jgarciahospital
Copy link
Collaborator Author

@sachinvodafone can you please review for merging?

@jgarciahospital jgarciahospital merged commit c57fa9e into main May 20, 2024
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-1 branch May 20, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

3 participants