Skip to content

Release PR r2.2 (second release candidate)#97

Merged
hdamker merged 8 commits intocamaraproject:mainfrom
hdamker:release-pr-r2.2
Feb 19, 2025
Merged

Release PR r2.2 (second release candidate)#97
hdamker merged 8 commits intocamaraproject:mainfrom
hdamker:release-pr-r2.2

Conversation

@hdamker
Copy link
Contributor

@hdamker hdamker commented Feb 18, 2025

What type of PR is this?

Add one of the following kinds:

  • correction
  • subproject management

What this PR does / why we need it:

  • Updated version number to v1.1.0-rc.2 and release to r2.2
  • Updated version in servers.url to /v1rc2/, in line with current guidelines
  • Updated README.md and CHANGELOG.md (new section for r2.2)

In addition:

  • Deleted outdated documentation/API_documentation/one-time-password-sms-API-Readiness-Checklist.md
  • Renamed documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md to one-time-password-sms-API-Readiness-Checklist.md
  • Updated one-time-password-sms-API-Readiness-Checklist.md from rc.1 to rc.2

Which issue(s) this PR fixes:

Fixes #96

Special notes for reviewers:

Please check if all necessary places are changed to be consistent
Note: Due to the three steps listed above the diff looks like that I'm updated on old v1.0.0 API Readiness-Checklist, which I didn't

@hdamker hdamker requested review from a team and jlurien February 18, 2025 20:42
@hdamker hdamker mentioned this pull request Feb 18, 2025
Closed
13 tasks
tanjadegroot
tanjadegroot requested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@tanjadegroot tanjadegroot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the changes
one correction needed on x-camara-commonalities
and a few additional ones for the team to check

code/API_definitions/one-time-password-sms.yaml
Copy link
Contributor

@tanjadegroot tanjadegroot Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 5: "Service Enabling Network Function API" --> "Service API"
line 8 - remove NaaS definition as not used and not explained/useful
line 9: reove the abbreviation "(OTAC")" as not used
line 439: update externalDocs link to point to "OTPValidation"
Note, the externalDocs section is usually after the Info section (in the beginning of the file)

Copy link
Contributor Author

@hdamker hdamker Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #98 for these

@hdamker @tanjadegroot
Update code/API_definitions/one-time-password-sms.yaml
c4bc2e9 
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
@hdamker
Copy link
Contributor Author

hdamker commented Feb 19, 2025 •
edited
Loading

OK for the changes one correction needed on x-camara-commonalities and a few additional ones for the team to check

The formal change committed, remaining points I propose to leave to the team in a separate PR (e.g. before public release) as this wasn't the scope of this second release candidate (see #96).

fernandopradocabrillo
fernandopradocabrillo approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @hdamker for making the PR

diegogonmar
diegogonmar approved these changes Feb 19, 2025
View reviewed changes
Copy link

@diegogonmar diegogonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hdamker @tanjadegroot, all, for the flexibility and support with this.

bigludo7
bigludo7 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hdamker

@hdamker hdamker mentioned this pull request Feb 19, 2025
Closed
@hdamker hdamker merged commit b9fd64e into camaraproject:main Feb 19, 2025
2 checks passed
@hdamker hdamker deleted the release-pr-r2.2 branch February 19, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigludo7 bigludo7 bigludo7 approved these changes

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes

@tanjadegroot tanjadegroot tanjadegroot approved these changes

@jlurien jlurien Awaiting requested review from jlurien

+1 more reviewer

@diegogonmar diegogonmar diegogonmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create new Release Candidate with the server URL aligned with current guidelines

5 participants

@hdamker @diegogonmar @bigludo7 @fernandopradocabrillo @tanjadegroot