Skip to content

Split the feature file in 2 files#101

Merged
bigludo7 merged 7 commits intomainfrom
fix94
Feb 26, 2025
Merged

Split the feature file in 2 files#101
bigludo7 merged 7 commits intomainfrom
fix94

Conversation

@bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Feb 25, 2025 •
edited
Loading

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Split the feature file in 2 files - one per operation.
No additional change

Which issue(s) this PR fixes:

Fixes #94

Special notes for reviewers:

As request by @hdamker ;)

Changelog input

 release-note
- Feature file split in 2 files.

Additional documentation

This section can be blank.

docs

@github-actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.63s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.76s
✅ YAML yamllint 1 0 0.32s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor

hdamker commented Feb 25, 2025 •
edited
Loading

@bigludo7 please reset the version to wip in the files or do - as @eric-murray would prefer as good practice - a short PR as first merge, which is resetting all versions across the files to wip.

@bigludo7 bigludo7 mentioned this pull request Feb 26, 2025
Merged
@bigludo7
Copy link
Collaborator Author

bigludo7 commented Feb 26, 2025

@bigludo7 please reset the version to wip in the files or do - as @eric-murray would prefer as good practice - a short PR as first merge, which is resetting all versions across the files to wip.

Thanks @hdamker !
Done ;)

fernandopradocabrillo
fernandopradocabrillo reviewed Feb 26, 2025
View reviewed changes
code/Test_Definitions/OTPValidation-send-code.feature Outdated
@@ -0,0 +1,204 @@
Feature: CAMARA OTPvalidationAPI, v1.1.0-rc.2 - operation sendCode
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just change to v1.1.0 so we have it already prepare for the public?

Suggested change
Feature: CAMARA OTPvalidationAPI, v1.1.0-rc.2 - operation sendCode
Feature: CAMARA OTPvalidationAPI, v1.1.0 - operation sendCode

Copy link
Collaborator Author

@bigludo7 bigludo7 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the previous PR it will be set to wip.

Then in the PR release I will set them to 1.1

Copy link
Collaborator Author

@bigludo7 bigludo7 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandopradocabrillo I've mix myself.
Finally I set it to wip and in the future release PR I will shift all to 1.1

@bigludo7
Copy link
Collaborator Author

bigludo7 commented Feb 26, 2025

In order to solve conflict I have to re-introduce the test case unified feature file and then I will create another PR to remove it....

@bigludo7 bigludo7 merged commit 96abf49 into main Feb 26, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix94 branch February 26, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandopradocabrillo fernandopradocabrillo fernandopradocabrillo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split the feature file in 2 files

3 participants

@bigludo7 @hdamker @fernandopradocabrillo