Add pattern validation for hashedPhoneNumber#188
Merged
bigludo7 merged 1 commit intocamaraproject:mainfrom May 21, 2025
Merged
Conversation
Collaborator
|
Works for me - But we have first to merge #191 to set back the version to wip. |
fernandopradocabrillo
approved these changes
Apr 23, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR introduces pattern validation for the hashedPhoneNumber parameter.
Previously, pattern validation was only applied to the phoneNumber field, ensuring it followed the E.164 format (i.e., starting with the country code and prefixed with +). However, when a user provides a hashedPhoneNumber, we cannot reverse it to verify the presence of the + prefix due to the nature of hashing.
To address this, we now enforce a pattern validation specifically for hashedPhoneNumber. The validation checks that the hash:
This approach ensures that the input format for hashedPhoneNumber remains consistent and secure, without relying on characteristics of the unhashed value.
Which issue(s) this PR fixes:
Fixes #189
Special notes for reviewers:
No functional change.
Changelog input
Add pattern validation for hashedPhoneNumber