Public Release for Fall24 meta-release by bigludo7 · Pull Request #139 · camaraproject/NumberVerification

bigludo7 · 2024-08-26T12:23:50Z

What type of PR is this?

Add one of the following kinds:

subproject management

What this PR does / why we need it:

Related to issue #107

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Missing link for Test Statement
PR for Test Definition no yet merged

Changelog input

 Public release number_verification v1.0.0

Additional documentation

This section can be blank.

docs

Set version to 1.0.0

Update Readiness Checklist

Update readme for r1.2

Update changelog for r1.2

github-actions · 2024-08-26T12:25:02Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Errors	Elapsed time
✅ ACTION	actionlint	2	0	0.03s
✅ OPENAPI	spectral	1	0	1.65s
✅ REPOSITORY	git_diff	yes	no	0.01s
✅ REPOSITORY	secretlint	yes	no	0.71s
✅ YAML	yamllint	1	0	0.3s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

hdamker

LGTM, one suggestion and one comment.

Please add @camaraproject/release-management_maintainers, as it is ready for review.

CHANGELOG.md

hdamker · 2024-08-27T08:50:49Z

documentation/API_documentation/NumberVerification-Readiness-Checklist.md

+|  7 | Basic API test cases & documentation         |   O   |         M         |    M    |    M   |   Y   | [PR #124](https://github.com/camaraproject/NumberVerification/pull/124/files) |
+|  8 | Enhanced API test cases & documentation      |   O   |         O         |    O    |    M   |   Y  | [PR #124](https://github.com/camaraproject/NumberVerification/pull/124/files) |


The status is either "tbd" with the PR, or you consider that PR 124 must be merged before the release PR, than you can already link here the coming .feature file.

We have just merged the Test Definition.
I've updated the rc1.2 branch accordingly.

Add link for the test definition

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Test PR to update branch

AxelNennker · 2024-08-28T09:02:59Z

Please review my ICM review on 1.1
camaraproject/IdentityAndConsentManagement#189 (comment)

rartych · 2024-08-28T10:47:04Z

The link in the last line of README.md is wrong.
It should go to https://wiki.camaraproject.org/display/CAM/NumberVerification or https://wiki.camaraproject.org/x/jQOeAQ

@rartych

Fixed link to meeting minutes (last ine) Thanks @rartych

hdamker · 2024-08-28T12:18:56Z

@bigludo7 please consider to fix #142 as part of this PR. Then all API YAMLs across the meta-release will have the same file name format.

Change number_verification to number-verification

Change name from number_verification to number-verification

Took into account file name change: number_verification.yaml to number-verification.yaml

bigludo7 · 2024-08-28T12:56:34Z

@bigludo7 please consider to fix #142 as part of this PR. Then all API YAMLs across the meta-release will have the same file name format.

Done :)

hdamker · 2024-08-28T16:21:46Z

code/Test_Definitions/NumberVerification_device_phone_number_share.feature

 # Input to be provided by the implementation to the tests
 # References to OAS spec schemas refer to schemas specified in
-# https://raw.githubusercontent.com/camaraproject/NumberVerification/main/code/API_definitions/number_verification.yaml
+# https://raw.githubusercontent.com/camaraproject/NumberVerification/main/code/API_definitions/number-verification.yaml


Is somewhere defined which version of the API definition the .feature file refers to? This link goes to main and therefore potentially into "wip".

Maybe a relative link would be better to stay within the tag/branch, but I don't think this is possibly for raw content. An alternative would be to link just to /code/API_definitions/number_verification.yaml

I've applied your suggestion.

Changed reference path to the yaml.

…y.feature

…e to number-verification-device-phone-number-share.feature + make linting happy

documentation/API_documentation/NumberVerification-Readiness-Checklist.md

…hecklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

rartych · 2024-08-30T12:12:12Z

In the path: section there is X-Correlator, the guideline was changed to use x-correlator (lower case)
https://github.com/camaraproject/Commonalities/pull/194/files

fixed X-Correlator to x-correlator.

bigludo7 · 2024-08-30T12:28:55Z

In the path: section there is X-Correlator, the guideline was changed to use x-correlator (lower case) https://github.com/camaraproject/Commonalities/pull/194/files

Thanks to catch this one Rafal
Fixed.

jlurien

Update versions in test plans: Given the resource "/number-verification/v0 -> Given the resource "/number-verification/v1

documentation/API_documentation/NumberVerification-Readiness-Checklist.md

…hecklist.md Co-authored-by: Jose Luis Urien <jlurien@gmail.com>

changed "/device-phone-number/v0" to "/device-phone-number/v1"

changed /number-verification/v0 to /number-verification/v1 in the background section

bigludo7 · 2024-09-03T12:30:29Z

Update versions in test plans: Given the resource "/number-verification/v0 -> Given the resource "/number-verification/v1

Thank @jlurien
fixed

jlurien · 2024-09-04T12:36:32Z

Let's wait to decision on camaraproject/ReleaseManagement#89 to merge this

Added sentences in doc as mentioned in #116

Add a line to indicate that we updated the documentation part of the yaml

bigludo7 · 2024-09-05T07:21:38Z

Following discussion in today WG meeting & sync with @hdamker I've updated the yaml to add a clarification before the sequence diagram. Changelog has been also updated.
@hdamker @fernandopradocabrillo @jlurien I will need your approval (I understood @AxelNennker is off this week).
Thanks.

code/API_definitions/number-verification.yaml

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

tanjadegroot · 2024-09-05T16:19:54Z

Please see camaraproject/ReleaseManagement#89 on how to update the Test result statement in the API readiness checklist for this Fall24 meta-release.

Taking care of the Test result statement accordingly to camaraproject/ReleaseManagement#89

bigludo7 · 2024-09-05T16:35:22Z

Please see camaraproject/ReleaseManagement#89 on how to update the Test result statement in the API readiness checklist for this Fall24 meta-release.

Thanks @tanjadegroot
Applied
cc @hdamker

jlurien

Release PR approved (on behalf of Release Management)

@bigludo7 PR ready to be merged and r1.2 can be created.Please update https://wiki.camaraproject.org/display/CAM/NumberVerification++API+Release+Tracking with date for M4 and link to r1.2 when it is created. Thanks

fernandopradocabrillo

LGTM

bigludo7 added 6 commits August 26, 2024 13:56

Update number_verification.yaml

86aa49f

Set version to 1.0.0

Update NumberVerification-Readiness-Checklist.md

0d3eef6

Update Readiness Checklist

Update README.md

dc2f6b3

Update readme for r1.2

Update CHANGELOG.md

06176c9

Update changelog for r1.2

Update CHANGELOG.md

41d7cc8

Update CHANGELOG.md

f212048

bigludo7 requested a review from hdamker August 26, 2024 12:23

bigludo7 requested review from AxelNennker and fernandopradocabrillo as code owners August 26, 2024 12:23

hdamker reviewed Aug 27, 2024

View reviewed changes

bigludo7 and others added 4 commits August 27, 2024 14:10

Update NumberVerification-Readiness-Checklist.md

9362093

Add link for the test definition

Update CHANGELOG.md

516ce18

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Merge pull request #140 from camaraproject/main

9bef3bd

Test PR to update branch

Update NumberVerification-Readiness-Checklist.md

d63676d

bigludo7 requested a review from a team August 27, 2024 14:11

hdamker mentioned this pull request Aug 27, 2024

NumberVerification r1.2 release review (M4 for stable version) camaraproject/ReleaseManagement#86

Closed

13 tasks

Update README.md

b640c9a

Fixed link to meeting minutes (last ine) Thanks @rartych

bigludo7 added 6 commits August 28, 2024 14:44

Rename number_verification.yaml to number-verification.yaml

e3eb206

Update NumberVerification_device_phone_number_share.feature

d5a475b

Update NumberVerification_verify.feature

bbf0b6e

Update README.md

75eb40a

Change number_verification to number-verification

Update CHANGELOG.md

c7194aa

Change name from number_verification to number-verification

Update NumberVerification-Readiness-Checklist.md

de14df7

Took into account file name change: number_verification.yaml to number-verification.yaml

hdamker reviewed Aug 28, 2024

View reviewed changes

Update NumberVerification_device_phone_number_share.feature

3498a3d

Changed reference path to the yaml.

bigludo7 added 4 commits August 29, 2024 09:41

Update NumberVerification_verify.feature

fc93ac2

Changed reference path to the yaml.

Update NumberVerification_verify.feature

91d35e0

Rename NumberVerification_verify.feature to number-verification-verif…

23777bd

…y.feature

Update and rename NumberVerification_device_phone_number_share.featur…

2d1e541

…e to number-verification-device-phone-number-share.feature + make linting happy

hdamker reviewed Aug 29, 2024

View reviewed changes

documentation/API_documentation/NumberVerification-Readiness-Checklist.md Outdated Show resolved Hide resolved

Update documentation/API_documentation/NumberVerification-Readiness-C…

f5e1a01

…hecklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

rartych mentioned this pull request Aug 29, 2024

Review the APIs which are targeting "stable" maturity in the Fall24 meta-release camaraproject/Commonalities#266

Closed

Update number-verification.yaml

c19dbec

fixed X-Correlator to x-correlator.

jlurien reviewed Sep 3, 2024

View reviewed changes

documentation/API_documentation/NumberVerification-Readiness-Checklist.md Outdated Show resolved Hide resolved

bigludo7 and others added 3 commits September 3, 2024 14:27

Update documentation/API_documentation/NumberVerification-Readiness-C…

85161c3

…hecklist.md Co-authored-by: Jose Luis Urien <jlurien@gmail.com>

Update number-verification-device-phone-number-share.feature

b988d0c

changed "/device-phone-number/v0" to "/device-phone-number/v1"

Update number-verification-verify.feature

d5dc23e

changed /number-verification/v0 to /number-verification/v1 in the background section

bigludo7 added 2 commits September 5, 2024 09:16

Update number-verification.yaml

2733d6f

Added sentences in doc as mentioned in #116

Update CHANGELOG.md

a758096

Add a line to indicate that we updated the documentation part of the yaml

hdamker reviewed Sep 5, 2024

View reviewed changes

code/API_definitions/number-verification.yaml Outdated Show resolved Hide resolved

Update code/API_definitions/number-verification.yaml

4453998

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>

Update NumberVerification-Readiness-Checklist.md

b3d5043

Taking care of the Test result statement accordingly to camaraproject/ReleaseManagement#89

jlurien approved these changes Sep 6, 2024

View reviewed changes

jlurien self-requested a review September 6, 2024 09:21

fernandopradocabrillo approved these changes Sep 6, 2024

View reviewed changes

rartych mentioned this pull request Sep 6, 2024

Test definitions - linting results #143

Closed

bigludo7 merged commit 714ac37 into main Sep 6, 2024

hdamker deleted the bigludo7/r1.2 branch September 6, 2024 17:55

		\| 7 \| Basic API test cases & documentation \| O \| M \| M \| M \| Y \| [PR #124](https://github.com/camaraproject/NumberVerification/pull/124/files) \|
		\| 8 \| Enhanced API test cases & documentation \| O \| O \| O \| M \| Y \| [PR #124](https://github.com/camaraproject/NumberVerification/pull/124/files) \|

Conversation

bigludo7 commented Aug 26, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for reviewers:

Changelog input

Additional documentation

Uh oh!

github-actions bot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦙 MegaLinter status: ✅ SUCCESS

Uh oh!

hdamker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hdamker Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

bigludo7 Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

AxelNennker commented Aug 28, 2024

Uh oh!

rartych commented Aug 28, 2024

Uh oh!

hdamker commented Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bigludo7 commented Aug 28, 2024

Uh oh!

hdamker Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bigludo7 Aug 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rartych commented Aug 30, 2024

Uh oh!

bigludo7 commented Aug 30, 2024

Uh oh!

jlurien left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bigludo7 commented Sep 3, 2024

Uh oh!

jlurien commented Sep 4, 2024

Uh oh!

bigludo7 commented Sep 5, 2024

Uh oh!

Uh oh!

tanjadegroot commented Sep 5, 2024

Uh oh!

bigludo7 commented Sep 5, 2024

Uh oh!

jlurien left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandopradocabrillo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Aug 26, 2024 •

edited

Loading

hdamker commented Aug 28, 2024 •

edited

Loading

hdamker Aug 28, 2024 •

edited

Loading

jlurien left a comment •

edited

Loading