Update API definition and Test definition to meet Fall25 meta-release requirements#11
Update API definition and Test definition to meet Fall25 meta-release requirements#11lihaojie-CMCC merged 12 commits intomainfrom
Conversation
|
@lihaojie-CMCC Don't have the time for detailed review, but happy to support with comments on points I see. I have mainly looked on the first YAML knowledge-base-manage.yaml, some comments might apply also to other two. Important point are the API names. They are very important for us here in CAMARA, and there is the guideline that file names, title in the API definitions and the server URL must be consistent. See CAMARA-API-Design-Guide.md#52-openapi-version and the following section there. " Currently I see: File name: knowledge-base-manage -> is the "manage" needed here? File name: qa-assistent-manage File name: qa-assistent-service |
|
Security: Use instead of (might be equivalent, but not as in the guidelines)
|
|
Path names: "Using lowercase words and hyphenation (kebab-case)" ... so BTW: Tags have to be consistent, defined is |
|
General hints:
|
|
x-correlator: "required: true" for the header is wrong, the parameter is optional for API consumers Please use the definition as in https://github.com/camaraproject/Commonalities/blob/main/artifacts/CAMARA_common.yaml x-correlator parameter is missing in the 2xx responses? |
|
Add required RFC 2229 description to uploadDate field: |
| status: 400 | ||
| code: MISSING_REQUIRED_PARAM | ||
| message: "Required parameter 'name' is missing" | ||
| GENERIC_400_{{SPECIFIC_CODE}}: |
There was a problem hiding this comment.
This is a placeholder in the CAMARA_common.yaml, to be replaced by your specific codes, in format {{API_NAME}}.{{SPECIFIC_CODE}}, e.g. QA_KNOWLEDGE_BASE.INVALID_DOCUMENT_FORMAT
|
Add the required externalDocs section: |
|
Add the mandatory text about additional CAMARA error responses into the (end of) info section (as of https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#33-error-responses---mandatory-template-for-infodescription-in-camara-api-specs) |
|
As of https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#64-mandatory-template-for-infodescription-in-camara-api-specs and https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#64-mandatory-template-for-infodescription-in-camara-api-specs add the mandatory template to the info description: |
Add x-correlator parameter in the 20x responses.
Add x-correlator parameter in the 20x responses.
|
Hi @hdamker , Thank you for taking the time to review our project! We truly appreciate your valuable input. We've addressed each of your suggestions individually in the latest updates. Please feel free to verify the modifications at your convenience. |
|
@lihaojie-CMCC all changes are looking good - I will not check now if they are complete as there will be anyway a release review on your M3 release PR. But one hint: the title of the PR says "meet alpha release requirements", but as you want to participate in the Fall25 meta-release (as indicated by the release trackers which you have created), you would need to create the release PR for the release-candidate versions (r1.1 with 0.1.0-rc.1) until end of the week. Alpha release is optional, so I recommend that you go directly to the release candidate. Please have a look on https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/API_Release_Guidelines.md#Releasing-an-API-step-by-step and prepare your release PR for r1.1 already in parallel. |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Prepare the alpha release r1.1:
This PR is an iteration based on PR #10
Which issue(s) this PR fixes:
Special notes for reviewers: