Skip to content

Align commonalities v0.5#34

Merged
jgarciahospital merged 2 commits intomainfrom
jgarciahospital-patch-8
Jan 27, 2025
Merged

Align commonalities v0.5#34
jgarciahospital merged 2 commits intomainfrom
jgarciahospital-patch-8

Conversation

@jgarciahospital
Copy link
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction
  • enhancement/feature

What this PR does / why we need it:

Include alignement with commonalities v0.5

Which issue(s) this PR fixes:

Fixes #30

Special notes for reviewers:

This PR also includes #33, so it should be merged before.

Changelog input

 release-note
- Change error structure definition to normalize error & status
- Update error code to introduce 429
- Remove 5xx errors
- Change in 422 code
- Add 3-legged token examples
- Improve documentation part
- Improve and align info.description section with Commonalities and ICM r2.1

Additional documentation

This section can be blank.

docs

bigludo7
bigludo7 previously approved these changes Jan 22, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks !!!

@jgarciahospital
Copy link
Contributor Author

Conflicts solved, @bigludo7 ready for review again.

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgarciahospital jgarciahospital merged commit 6b91045 into main Jan 27, 2025
1 check passed
@jgarciahospital jgarciahospital deleted the jgarciahospital-patch-8 branch January 27, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope for Spring25 release (in preparation)

2 participants