Merged
Conversation
First API proposal, including both endpoint functionality as part of the same API yaml
bigludo7
reviewed
Sep 20, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Thanks
Look globally good for me. Just a small request to add 422 for alignement with other API.
bigludo7
reviewed
Sep 23, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Strange - I've a parser error on my favorite swagger ui for lines 62-63 :(
Should be:
license:
name: Apache 2.0
url: https://www.apache.org/licenses/LICENSE-2.0.html
version: wip
x-camara-commonalities: 0.4.0
Contributor
Author
Solved... indentation typo |
Contributor
Author
|
Thanks ludovic for the review! Should we merge and continue the discussion, in another PR, about the API description (as in #11)? |
Collaborator
|
Let keep this week for @krishvenkatachalam to provide feedback? Does it work for you Jorge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
First API proposal, including both endpoint functionality as part of the same API yaml.
Documentation will need to also include detailed description for the kind of scenarios where a Device Swap is considered, per #11 discussion.
Which issue(s) this PR fixes:
Fixes #6