Skip to content

Fix Typo in response of CountryName & File name#30

Merged
eric-murray merged 3 commits intocamaraproject:mainfrom
ravindrapalaskar17:fix-typo-in-response-parameter-countryName
Mar 7, 2023
Merged

Fix Typo in response of CountryName & File name#30
eric-murray merged 3 commits intocamaraproject:mainfrom
ravindrapalaskar17:fix-typo-in-response-parameter-countryName

Conversation

@ravindrapalaskar17
Copy link
Contributor

  1. Fix typo in Response of country Name
  2. Update the file name to> device-status.yaml

1. Fix typo in Response of country Name
2. Update the file name to> device-status.yaml
@ravindrapalaskar17
Copy link
Contributor Author

This PR is for fix the issue--> #27
@monamok @eric-murray please review

@monamok
Copy link
Contributor

monamok commented Mar 3, 2023

Thank you @ravindrapalaskar17.

@eric-murray
Copy link
Collaborator

@ravindrapalaskar17
An empty array is really [], not [ ]. As we are specifying the response and ideally all implementations will give the same response, it is probably better to be pedantic, so I made the change.

@ravindrapalaskar17
Copy link
Contributor Author

@ravindrapalaskar17 An empty array is really [], not [ ]. As we are specifying the response and ideally all implementations will give the same response, it is probably better to be pedantic, so I made the change.

Thanks @eric-murray

@ravindrapalaskar17
Copy link
Contributor Author

Can we merge this PR..?

eric-murray
eric-murray previously approved these changes Mar 7, 2023
@eric-murray eric-murray merged commit 29ac1f1 into camaraproject:main Mar 7, 2023
@eric-murray
Copy link
Collaborator

Merged as v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants