[device-status-subscriptions]: remove allOf in sinkcredential#226
Merged
akoshunyadi merged 1 commit intocamaraproject:mainfrom Dec 1, 2024
Merged
[device-status-subscriptions]: remove allOf in sinkcredential#226akoshunyadi merged 1 commit intocamaraproject:mainfrom
allOf in sinkcredential#226akoshunyadi merged 1 commit intocamaraproject:mainfrom
Conversation
akoshunyadi
approved these changes
Nov 19, 2024
Collaborator
|
@akoshunyadi As this is already defined as such in the yaml template for first meta release, this is not an issue to merge this before next MR. But no problem for me to keep it. |
sachinvodafone
approved these changes
Nov 20, 2024
Collaborator
Yes, the template has it correctly, so it's a kind of bug here. But I wouldn't create a fix for it, just release in Spring25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Removing this
allOf.It was discovered for some code-generator, it will produce unexpected behaviours having the
descriptioninside theallOf.Which issue(s) this PR fixes:
Fixes #225
Changelog input