[device-reachability-status]: support for reachability with multiple connectivity-types#221
Merged
eric-murray merged 11 commits intocamaraproject:mainfrom Nov 8, 2024
Conversation
eric-murray
reviewed
Oct 30, 2024
eric-murray
reviewed
Oct 30, 2024
eric-murray
reviewed
Oct 30, 2024
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
reviewed
Oct 30, 2024
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
reviewed
Oct 30, 2024
Co-authored-by: Eric Murray <eric.murray@vodafone.com>
eric-murray
previously approved these changes
Oct 30, 2024
bigludo7
reviewed
Oct 30, 2024
Collaborator
bigludo7
left a comment
There was a problem hiding this comment.
Line 78 should be - url: "{apiRoot}/device-reachability-status/vwip" no?
Collaborator
|
Please don't merge until the patch release is out! Thanks! |
eric-murray
approved these changes
Nov 6, 2024
sachinvodafone
approved these changes
Nov 6, 2024
Contributor
Author
|
@akoshunyadi & @bigludo7 I guess we can merge it now, agree? |
Collaborator
|
yes, now the main branch is free for development |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds a support, when a device is reachable via multiple connectivity-types, e.g. SMS & DATA.
Which issue(s) this PR fixes:
Fixes #140