Merged
Conversation
hdamker
previously requested changes
Oct 10, 2024
Contributor
hdamker
left a comment
There was a problem hiding this comment.
@akoshunyadi please touch also shortly the API-Readiness-Checklist (first line only). And add @camaraproject/release-management_maintainers - all LGTM but as it is a public review and there need to be some updates done (e.g. the CAMARA Readme), Release Management must be involved.
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
Collaborator
Author
|
Review findings done, the review by https://github.com/orgs/camaraproject/teams/release-management_maintainers was already requested |
12 tasks
Requested changes have been applied, Github still not satisfied
sachinvodafone
previously approved these changes
Oct 17, 2024
Collaborator
Author
|
@camaraproject/release-management_maintainers kindly asking for final review |
documentation/API_documentation/device-reachability-status-API-Readiness-Checklist.md
Show resolved
Hide resolved
...tation/API_documentation/device-reachability-status-subscriptions-API-Readiness-Checklist.md
Show resolved
Hide resolved
documentation/API_documentation/device-roaming-status-subscriptions-API-Readiness-Checklist.md
Show resolved
Hide resolved
|
In addition to the PR comments, I saw some further points: README.me:
|
Collaborator
Author
|
@bigludo7 now it should be perfect 🙂 |
|
Great ! OK from Release Management /LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Prepare patch release r1.3
Which issue(s) this PR fixes:
Special notes for reviewers:
Changelog input
Additional documentation