Add missing protocol-components for device-roaming-status-subscriptions#208
Merged
akoshunyadi merged 2 commits intocamaraproject:mainfrom Sep 19, 2024
Merged
Conversation
sachinvodafone
previously approved these changes
Sep 17, 2024
akoshunyadi
approved these changes
Sep 18, 2024
akoshunyadi
requested changes
Sep 18, 2024
Collaborator
akoshunyadi
left a comment
There was a problem hiding this comment.
Sorry, just forgot about it. The first change after 0.6.0 should set the version back to wip.
3ebdf89
Collaborator
|
@maxl2287 now you set the version for all of the APIs to wip. I think generally it is not necessary, because it is possible that an API remains unchanged in the upcoming version, so only the changed API should be set to wip and later for the release to the new version. Of course we could set the previous version again, if there was no change... Anyway, let's keep it for now. |
akoshunyadi
approved these changes
Sep 19, 2024
eric-murray
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR adds the missing components, which were referenced in the
protocol-discriminatorWhich issue(s) this PR fixes:
Fixes #207