Subscription-APIs: Alignment of errors with Commonalities#193
Conversation
bigludo7
left a comment
There was a problem hiding this comment.
Max, I've only review code/API_definitions/device-reachability-status-subscriptions.yaml and got a couple of comments for your consideration:
- Probably 2 422 examples are missing
- not sure why we should not remove 429 as it is part of the template finnally
Same comment should apply for device-roaming-status-subscriptions.yaml
code/API_definitions/device-reachability-status-subscriptions.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscriptions.yaml
Outdated
Show resolved
Hide resolved
|
@bigludo7 updates are done. |
|
I've noticed that there are quite a lot of differences to the template. Which has already differences to the design guidelines. :-) Btw. the last change of the template will be released in RC2 of the Commonalities Release, so currently we are conform with the RC1. |
akoshunyadi
left a comment
There was a problem hiding this comment.
As discussed, regarding the error codes we should make one more round about the subscription template + implementations. For the RC1 it LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Alignement of errors according to Commonalities guideline.
Which issue(s) this PR fixes:
Fixes #184
Changelog input