split /subscription-endpoints into seperate APIs#161
split /subscription-endpoints into seperate APIs#161akoshunyadi merged 8 commits intocamaraproject:mainfrom
/subscription-endpoints into seperate APIs#161Conversation
|
Thanks @maxl2287 for the effort. |
|
@bigludo7 tbh I would handle this in a seperate PR 😄 Do you both agree? |
Works for me. |
|
ok for me. Yes, then then we need an additional PR for the subscriptions. |
bigludo7
left a comment
There was a problem hiding this comment.
OK for me in order to move forward to the new model.
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
|
@sachinvodafone thanks for the findings! |
|
@bigludo7 can we label this as |
akoshunyadi
left a comment
There was a problem hiding this comment.
Just some typos... the big rework based on the new template will come anyway..
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
…s-subscriptions.yaml
|
@bigludo7 I was needed to update the file-name to Please review again :) |
bigludo7
left a comment
There was a problem hiding this comment.
We need to align with PR213 outcomes for the error linked to the device identifier but in order to not manage too complex PR I will prefer to merge this one and then raise another issue/PR to manage 213.
@maxl2287 @akoshunyadi @sachinvodafone WDYT?
| - $ref: '#/components/parameters/x-correlator' | ||
| security: | ||
| - openId: | ||
| - reachability-status:subscriptions:create |
There was a problem hiding this comment.
Actually the scope should be api-name:[resource:]action, so in this case device-reachabilty-status-subscriptions:create
(applies to other scopes in this PR too)
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Splits up the subscription-endpoints for reachability and roaming status into seperate YAML-files.
Which issue(s) this PR fixes:
Fixes #125