Skip to content

renaming "EventType"-components to be more clear & update component descriptions#141

Merged
bigludo7 merged 2 commits intocamaraproject:mainfrom
maxl2287:fix/renaming-event-type-components
Apr 25, 2024
Merged

renaming "EventType"-components to be more clear & update component descriptions#141
bigludo7 merged 2 commits intocamaraproject:mainfrom
maxl2287:fix/renaming-event-type-components

Conversation

@maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Apr 15, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

This PR makes more clear, what Event-Types are used for notification and updates some descriptions of the components.
Also the "subscriptionId" in the "subscription-ends"-event is now mandatory.

Which issue(s) this PR fixes:

Fixes #142

@maxl2287 maxl2287 changed the title fix: renaming "EventType"-components to be more clear fix: renaming "EventType"-components to be more clear & update component descriptions Apr 15, 2024
@maxl2287 maxl2287 changed the title fix: renaming "EventType"-components to be more clear & update component descriptions renaming "EventType"-components to be more clear & update component descriptions Apr 15, 2024
@akoshunyadi akoshunyadi added the v0.6.0 Planned for release v0.6.0 label Apr 17, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@bigludo7 bigludo7 merged commit 98ac611 into camaraproject:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.6.0 Planned for release v0.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update naming of "EventType"-components and other descriptions

4 participants