Updated in-line documentation for Roaming to clarify that country information can optionally be returned in the response.#127
Merged
akoshunyadi merged 1 commit intocamaraproject:mainfrom Mar 27, 2024
Conversation
Updating in-line documentation for Roaming to clarify that country information can optionally be returned in the response.
Closed
akoshunyadi
approved these changes
Mar 14, 2024
Collaborator
|
@sachinvodafone if you can review - this is an easy one ;) |
sachinvodafone
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Small update of in-line documentation for Roaming to clarify that country information can optionally be returned in the response. Previous documentation implied that country information was mandatory when roaming is true.
Which issue(s) this PR fixes:
Fixes #124
Special notes for reviewers:
As discussed in DeviceStatus meeting on 13-03-24. It was agreed that country information is optional in cases of roaming=true.
Changelog input