Update error schema for compliance with Commonalities r3.3#45
Merged
eric-murray merged 2 commits intocamaraproject:mainfrom Aug 27, 2025
Merged
Update error schema for compliance with Commonalities r3.3#45eric-murray merged 2 commits intocamaraproject:mainfrom
eric-murray merged 2 commits intocamaraproject:mainfrom
Conversation
sachinvodafone
approved these changes
Aug 26, 2025
bigludo7
reviewed
Aug 26, 2025
Contributor
bigludo7
left a comment
There was a problem hiding this comment.
Thanks Eric - I've same concern that for Device ReacheabilityStatus and camaraproject/Commonalities#515. I think it should be in this order in the required in ErrorInfo : status->code->message.
Contributor
Author
|
Hi @bigludo7 We can discuss at the Device Status meeting tomorrow. I raised this PR so that we would have a PR in place for compliance with Commonalities r3.3, as we are running out of time for the meta-release. If there is a Commonalities r3.4, or if we decide not to adopt the Commonalities schema, then I can modify or delete the PR. |
Contributor
|
Thanks @eric-murray for the clarification - let's wait for the discussion. I've kept the previous order in some API but then not sure I'm right :) |
bigludo7
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR updates the error schema for compliance with Commonalities r3.3
Which issue(s) this PR fixes:
Fixes #N/A
Special notes for reviewers:
None
Changelog input
Additional documentation
None