Skip to content

Commonalities alignement for device roaming subscription#37

Merged
akoshunyadi merged 3 commits intomainfrom
fix36
Jul 10, 2025
Merged

Commonalities alignement for device roaming subscription#37
akoshunyadi merged 3 commits intomainfrom
fix36

Conversation

@bigludo7
Copy link
Contributor

@bigludo7 bigludo7 commented Jul 4, 2025 •
edited
Loading

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Following commonalities enhancement (here) this PR fixes 2 points:

  • Add pattern for sink & add error if not followed
  • make subscription id in async subscription response

Which issue(s) this PR fixes:

Fixes #36

Special notes for reviewers:

Changelog input

 release-note
- add pattern for sink 
- add error 400 INVALID_SINK in the yaml
- add test case for 400 INVALID_SINK
- make subscription id mandatory in async subscription response
- add missing RFC3339 format description for LastStatusTime

Additional documentation

This section can be blank.

docs

bigludo7 added 2 commits July 4, 2025 16:29
@bigludo7
Update device-roaming-status-subscriptions.yaml
56d28a3 
sink attribute improvements & subscription id mandatory in aSync creation
@bigludo7
Add scenario for invalid sink url
a8aa6ba
@github-actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 3.73s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.66s
✅ YAML yamllint 2 0 0.68s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7 bigludo7 added the Fall25 label Jul 4, 2025
akoshunyadi
akoshunyadi previously approved these changes Jul 7, 2025
View reviewed changes
sachinvodafone
sachinvodafone previously approved these changes Jul 7, 2025
View reviewed changes
@bigludo7 bigludo7 dismissed stale reviews from sachinvodafone and akoshunyadi via d6993ed July 8, 2025 15:00
@akoshunyadi akoshunyadi merged commit fbe4d7e into main Jul 10, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix36 branch November 5, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoshunyadi akoshunyadi akoshunyadi approved these changes

@sachinvodafone sachinvodafone sachinvodafone approved these changes

@eric-murray eric-murray Awaiting requested review from eric-murray eric-murray is a code owner

Assignees

No one assigned

Labels

Fall25

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align device-roaming-status-subscriptions.yaml with Commonalities

3 participants

@bigludo7 @akoshunyadi @sachinvodafone