Rename subscription-ends event to subscription-ended#31
Merged
akoshunyadi merged 5 commits intocamaraproject:mainfrom Jul 1, 2025
Merged
Rename subscription-ends event to subscription-ended#31akoshunyadi merged 5 commits intocamaraproject:mainfrom
subscription-ends event to subscription-ended#31akoshunyadi merged 5 commits intocamaraproject:mainfrom
Conversation
sachinvodafone
previously approved these changes
Jun 24, 2025
bigludo7
previously approved these changes
Jun 29, 2025
sachinvodafone
previously approved these changes
Jun 30, 2025
Contributor
|
There are still such names there: SUBSCRIPTION_ENDS, EventSubscriptionEnds, SubscriptionEnds |
ed2824d
Contributor
Author
OK, done |
sachinvodafone
approved these changes
Jun 30, 2025
akoshunyadi
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Commonalities has renamed the
subscription-endsevent tosubscription-ended. This PR renames the event where it is used.The redundant
NotificationEventTypeschema is also removed.Which issue(s) this PR fixes:
Fixes #28
Special notes for reviewers:
I've not added the
subscription-startedorsubscription-updatedevents as these are optional and require discussion.Changelog input
Additional documentation
None