Skip to content

Commonalities alignement for device reachability subscription#36

Merged
akoshunyadi merged 4 commits intomainfrom
fix35
Jul 10, 2025
Merged

Commonalities alignement for device reachability subscription#36
akoshunyadi merged 4 commits intomainfrom
fix35

Conversation

@bigludo7
Copy link
Contributor

@bigludo7 bigludo7 commented Jul 4, 2025 •
edited
Loading

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Following commonalities enhancement (here) this PR fixes 2 points:

  • Add pattern for sink & add error if not followed
  • make subscription id mandatory in async subscription response

Which issue(s) this PR fixes:

Fixes #35

Special notes for reviewers:

Changelog input

 release-note
- add pattern for sink 
- add error 400 INVALID_SINK in the yaml
- add test case for 400 INVALID_SINK
- make subscription id mandatory in async subscription response
- add RFC3339 format description for LastStatusTime

Additional documentation

This section can be blank.

docs

@bigludo7 bigludo7 added the Fall25 label Jul 4, 2025
@github-actions
Copy link

github-actions bot commented Jul 4, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 2 0 4.0s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.75s
✅ YAML yamllint 2 0 0.71s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

akoshunyadi
akoshunyadi previously approved these changes Jul 7, 2025
View reviewed changes
sachinvodafone
sachinvodafone previously approved these changes Jul 7, 2025
View reviewed changes
@hdamker
Copy link
Contributor

hdamker commented Jul 8, 2025

@bigludo7

Consider to address also the missing RFC3339 format description

LastStatusTime:
  description: |
    Last time that the associated device reachability status was updated.
    It must follow [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339#section-5.6) and must have time zone. 
    Recommended format is yyyy-MM-dd'T'HH:mm:ss.SSSZ (i.e. which allows 2023-07-03T14:27:08.312+02:00 or 2023-07-03T12:27:08.312Z)
  type: string
  format: date-time
  example: "2024-02-20T10:41:38.657Z"

@bigludo7 bigludo7 dismissed stale reviews from sachinvodafone and akoshunyadi via e6cc234 July 8, 2025 14:55
eric-murray
eric-murray previously approved these changes Jul 8, 2025
View reviewed changes
akoshunyadi
akoshunyadi reviewed Jul 10, 2025
View reviewed changes
code/API_definitions/device-reachability-status.yaml Outdated
Recommended format is yyyy-MM-dd'T'HH:mm:ss.SSSZ (i.e. which allows 2023-07-03T14:27:08.312+02:00 or 2023-07-03T12:27:08.312Z)
type: string
format: date-time
example: "2024-02-20T10:41:38.657Z"
Copy link
Contributor

@akoshunyadi akoshunyadi Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an indentation problem here

Copy link
Contributor Author

@bigludo7 bigludo7 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :)

@akoshunyadi akoshunyadi merged commit 1c1e4d2 into main Jul 10, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix35 branch December 22, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoshunyadi akoshunyadi akoshunyadi approved these changes

@eric-murray eric-murray eric-murray approved these changes

@sachinvodafone sachinvodafone sachinvodafone left review comments

Assignees

No one assigned

Labels

Fall25

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align device-reachability-status-subscriptions.yaml with Commonalities

5 participants

@bigludo7 @hdamker @akoshunyadi @eric-murray @sachinvodafone