Define new geofencing subscriptions API with event subscription endpoint#98
Conversation
resolved review comments
removed extra boolean variables
Add device and area
Changed yaml file based on last review comments
Resolved review comments
Please check this last commit. All the review comments applied.
updated eventDetail
Deleted EventBase object, now all other events inherit from Event object and there is no "anyOf" in the Event anymore
Create EventTypeNotification which inherit from EventType, now in create subscription we do not have SUBSCRIPTION_ENDS and only in notification we use that.
Created NotifiedEventType enum with 3 values
change the api name to geofencing
rename yaml file to geofencing
changed the title and description of API based on new name
bigludo7
left a comment
There was a problem hiding this comment.
Thanks @maxl2287 for the subscription.
Please see some comments for your consideration in my review.
The most significant is about the event type granularity. I was expecting to have distinct event for entered and exit. Let's discuss this.
|
Thanks for your review @bigludo7! |
…ecific types for area left and entered
|
@jlurien I am using, e.g., a swagger editor to validate my written schemas. Could you please check if this is at least it is specified good or not here: Area:
type: object
properties:
areaType:
$ref: '#/components/schemas/AreaType'
required:
- areaType
discriminator:
propertyName: 'areaType'
mapping:
CIRCLE: "#/components/schemas/Circle"
AreaType:
type: string
description: |
Type of this area.
CIRCLE - The area is defined as a circle.
enum:
- CIRCLE
Circle:
description: Circular area
allOf:
- $ref: '#/components/schemas/Area'
- type: object
properties:
center:
$ref: '#/components/schemas/Point'
radius:
type: integer
description: Expected accuracy for the subscription event of device location in m, from location (radius)
minimum: 2000
maximum: 200000
required:
- center
- radius
example:
areaType: CIRCLE
center:
latitude: 50.735851
longitude: 7.10066
radius: 50000
Thanks in advance |
bigludo7
left a comment
There was a problem hiding this comment.
Thanks for the contribution;
Some very small corrections to fix the tag.
One question: Do you plan to provide the documentation in this PR or prefer to merge this one only with the yaml and have another for the documentation?
@bigludo7 Thanks for the review. Yes I will add the documentation asap in this PR |
…et" & removed securitySchemes
|
@maxl2287 Thanks for the corrections. |
|
@bigludo7 short question about "CreateSubscription". But does it make sense? |
@maxl2287 That's a fair question. In the context of geofencing API, as it the device status API, I think that making createSubscription mandatory makes a lot of sense ! |
|
@bigludo7 ready now to be rereviewed 🚀 |
jlurien
left a comment
There was a problem hiding this comment.
Some final comments. I think it's quite mature to be merged as -wip after some few adjustments.
jlurien
left a comment
There was a problem hiding this comment.
We can leave the default for basePath as you propose until it is fully aligned in Commonalities and Release Management, so we can progress with this PR.
…y + security using openId

What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Add CloudEvent subscription endpoints.
Which issue(s) this PR fixes:
Fixes #18
Note to reviewers
This PR is a clone to #74
In the fact that I am not allowed to add commits to Chia's repository and he is not part of the CAMARA project anymore.