Skip to content

Update path name#35

Merged
jlurien merged 1 commit intocamaraproject:mainfrom
rartych:patch-1
Mar 15, 2023
Merged

Update path name#35
jlurien merged 1 commit intocamaraproject:mainfrom
rartych:patch-1

Conversation

@rartych
Copy link
Collaborator

@rartych rartych commented Mar 13, 2023

What type of PR is this?

  • correction

What this PR does / why we need it:

Proposal to rename path from /verify to /verifications, to align with guidelines

Which issue(s) this PR fixes:

Fixes Issue #30

Special notes for reviewers:

Here is the trial of PR Template

Changelog input

 Path name was changed from `/verify` to `/verifications`

Additional documentation

Design guidelines 4.1:

The URI at the business entity level will always be a plural noun.

Change of path name
@rartych rartych changed the title Update location.yaml Update path name Mar 13, 2023
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice template !
Regarding the PR works for me as alignment with guideline.
Please let's wait our meeting tomorrow for merging.
Thanks

@jlurien
Copy link
Collaborator

jlurien commented Mar 13, 2023

We were proposing PRs to dev-0.2.0 branch, but as we are going to change this, we can keep this and resolve conflicts before merging

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit 49fe0e1 into camaraproject:main Mar 15, 2023
@rartych rartych deleted the patch-1 branch December 4, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Path name

3 participants